Review Request 110306: Add a new context menu action "New Folder with Selected Items" to Dolphins Context Menu.

Discussion:

Emmanuel Pescosta

2013-05-04 19:37:25 UTC

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110306/
-----------------------------------------------------------

Review request for Dolphin and Frank Reininghaus.

Description
-------

Add a new context menu action "New Folder with Selected Items" to Dolphins Context Menu.

When multiple items are selected, Dolphin offers this new action, to move the selected files/folders into a new folder.

Old Workflow:
Select files/folders -> Cut them -> Create a new folder -> Paste them into this new folder

New Workflow:
Select files/folders -> Create a new folder with the selected items

I hope you and the other Dolphin users/developers like it! ;)

Diffs
-----

dolphin/src/dolphincontextmenu.h 3d0005d
dolphin/src/dolphincontextmenu.cpp bb26c7a
dolphin/src/dolphinmainwindow.cpp 8ed31de
dolphin/src/views/dolphinview.h e50dffc
dolphin/src/views/dolphinview.cpp abf572f

Diff: http://git.reviewboard.kde.org/r/110306/diff/

Testing
-------

1. Select multiple folders/files
2. Open Item Context Menu
3. Select first action "New Folder with Selected Items"
4. Type the name of the new folder
5. Press the "Ok" button

Result should be:
* A new folder with the given name (4.) should be created and the previously selected items should be moved into this folder.
* If the folder already exists or if you haven't enough permissions, a error message should appear and the items should not be moved.

Works for me.

Thanks,

Emmanuel Pescosta

Frank Reininghaus

2013-05-05 14:54:22 UTC

Permalink

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110306/#review32091
-----------------------------------------------------------

Thanks Emmanuel for the idea! I'm sure that some people will like it, but could this not be implemented as a service menu or a KAbstractFileItemAction plugin? This is the preferred way to add actions that work on the selected files because users who need this functionality can install it easily, and the action does not clutter the context menu for everyone else.

- Frank Reininghaus

Post by Emmanuel Pescosta
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/110306/
-----------------------------------------------------------
(Updated May 4, 2013, 7:37 p.m.)
Review request for Dolphin and Frank Reininghaus.
Description
-------
Add a new context menu action "New Folder with Selected Items" to Dolphins Context Menu.
When multiple items are selected, Dolphin offers this new action, to move the selected files/folders into a new folder.
Select files/folders -> Cut them -> Create a new folder -> Paste them into this new folder
Select files/folders -> Create a new folder with the selected items
I hope you and the other Dolphin users/developers like it! ;)
Diffs
-----
dolphin/src/dolphincontextmenu.h 3d0005d
dolphin/src/dolphincontextmenu.cpp bb26c7a
dolphin/src/dolphinmainwindow.cpp 8ed31de
dolphin/src/views/dolphinview.h e50dffc
dolphin/src/views/dolphinview.cpp abf572f
Diff: http://git.reviewboard.kde.org/r/110306/diff/
Testing
-------
1. Select multiple folders/files
2. Open Item Context Menu
3. Select first action "New Folder with Selected Items"
4. Type the name of the new folder
5. Press the "Ok" button
* A new folder with the given name (4.) should be created and the previously selected items should be moved into this folder.
* If the folder already exists or if you haven't enough permissions, a error message should appear and the items should not be moved.
Works for me.
Thanks,
Emmanuel Pescosta

Emmanuel Pescosta

2013-05-05 14:59:01 UTC

Permalink

Post by Frank Reininghaus

Post by Frank Reininghaus
Thanks Emmanuel for the idea! I'm sure that some people will like it, but could this not be implemented as a service menu or a KAbstractFileItemAction plugin? This is the preferred way to add actions that work on the selected files because users who need this functionality can install it easily, and the action does not clutter the context menu for everyone else.

but could this not be implemented as a service menu or a KAbstractFileItemAction plugin?

I will give it a try, never implemented a service menu before. ;)

- Emmanuel

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110306/#review32091
-----------------------------------------------------------

Post by Frank Reininghaus
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/110306/
-----------------------------------------------------------
(Updated May 4, 2013, 7:37 p.m.)
Review request for Dolphin and Frank Reininghaus.
Description
-------
Add a new context menu action "New Folder with Selected Items" to Dolphins Context Menu.
When multiple items are selected, Dolphin offers this new action, to move the selected files/folders into a new folder.
Select files/folders -> Cut them -> Create a new folder -> Paste them into this new folder
Select files/folders -> Create a new folder with the selected items
I hope you and the other Dolphin users/developers like it! ;)
Diffs
-----
dolphin/src/dolphincontextmenu.h 3d0005d
dolphin/src/dolphincontextmenu.cpp bb26c7a
dolphin/src/dolphinmainwindow.cpp 8ed31de
dolphin/src/views/dolphinview.h e50dffc
dolphin/src/views/dolphinview.cpp abf572f
Diff: http://git.reviewboard.kde.org/r/110306/diff/
Testing
-------
1. Select multiple folders/files
2. Open Item Context Menu
3. Select first action "New Folder with Selected Items"
4. Type the name of the new folder
5. Press the "Ok" button
* A new folder with the given name (4.) should be created and the previously selected items should be moved into this folder.
* If the folder already exists or if you haven't enough permissions, a error message should appear and the items should not be moved.
Works for me.
Thanks,
Emmanuel Pescosta

Emmanuel Pescosta

2013-05-08 10:55:17 UTC

Permalink

Post by Emmanuel Pescosta

I will give it a try, never implemented a service menu before. ;)

Just a question: Is it possible to mark a url as current with a service menu/KAbstractFileItemAction plugin?

Because I think, that scrolling to the newly created folders make sense. ;)

- Emmanuel

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110306/#review32091
-----------------------------------------------------------

Frank Reininghaus

2013-05-10 09:13:27 UTC

Permalink

Post by Emmanuel Pescosta

I will give it a try, never implemented a service menu before. ;)
Just a question: Is it possible to mark a url as current with a service menu/KAbstractFileItemAction plugin?
Because I think, that scrolling to the newly created folders make sense. ;)

I think that this is not possible.

- Frank

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110306/#review32091
-----------------------------------------------------------

Emmanuel Pescosta

2013-05-15 20:11:35 UTC

Permalink

Post by Emmanuel Pescosta

Thanks for the information.

It's a pity, that this doesn't work, because scrolling to the newly created folder would be really great I think.

- Emmanuel

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110306/#review32091
-----------------------------------------------------------

Emmanuel Pescosta

2013-05-28 08:32:34 UTC

Permalink

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110306/
-----------------------------------------------------------

(Updated May 28, 2013, 8:32 a.m.)

Status
------

This change has been discarded.

Review request for Dolphin and Frank Reininghaus.

Description
-------

Add a new context menu action "New Folder with Selected Items" to Dolphins Context Menu.

When multiple items are selected, Dolphin offers this new action, to move the selected files/folders into a new folder.

Old Workflow:
Select files/folders -> Cut them -> Create a new folder -> Paste them into this new folder

New Workflow:
Select files/folders -> Create a new folder with the selected items

I hope you and the other Dolphin users/developers like it! ;)

Diffs
-----

dolphin/src/dolphincontextmenu.h 3d0005d
dolphin/src/dolphincontextmenu.cpp bb26c7a
dolphin/src/dolphinmainwindow.cpp 8ed31de
dolphin/src/views/dolphinview.h e50dffc
dolphin/src/views/dolphinview.cpp abf572f

Diff: http://git.reviewboard.kde.org/r/110306/diff/

Testing
-------

1. Select multiple folders/files
2. Open Item Context Menu
3. Select first action "New Folder with Selected Items"
4. Type the name of the new folder
5. Press the "Ok" button

Result should be:
* A new folder with the given name (4.) should be created and the previously selected items should be moved into this folder.
* If the folder already exists or if you haven't enough permissions, a error message should appear and the items should not be moved.

Works for me.

Thanks,

Emmanuel Pescosta