Kai Uwe Broulik
2018-09-26 09:59:18 UTC
broulik created this revision.
broulik added reviewers: Frameworks, dfaure, anthonyfieroni, jtamate.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
broulik requested review of this revision.
REVISION SUMMARY
Otherwise `PreviewJob` will refuse to re-use cache files generated by the directory thumbnailer.
TEST PLAN
Noticed that when I had a folder with a PDF in it (which takes a while to generate) that despite the folder thumbnails having generated a cache file, it would not use it when I entered the directory and instead recreate it again.
With this patch the thumbnails generated by the folder thumbnailer are accepted and previews when entering a folder with few files for the first time is noticeably faster. It doesn't change perception a lot when there are many files.
I don't have access to the plugin there so I don't add the version information to it. Not sure this could be a problem? It's a bit annoying that thumbnailer KIO duplicates so much code from the preview job already :/
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D15763
AFFECTED FILES
thumbnail/thumbnail.cpp
To: broulik, #frameworks, dfaure, anthonyfieroni, jtamate
Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp
broulik added reviewers: Frameworks, dfaure, anthonyfieroni, jtamate.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
broulik requested review of this revision.
REVISION SUMMARY
Otherwise `PreviewJob` will refuse to re-use cache files generated by the directory thumbnailer.
TEST PLAN
Noticed that when I had a folder with a PDF in it (which takes a while to generate) that despite the folder thumbnails having generated a cache file, it would not use it when I entered the directory and instead recreate it again.
With this patch the thumbnails generated by the folder thumbnailer are accepted and previews when entering a folder with few files for the first time is noticeably faster. It doesn't change perception a lot when there are many files.
I don't have access to the plugin there so I don't add the version information to it. Not sure this could be a problem? It's a bit annoying that thumbnailer KIO duplicates so much code from the preview job already :/
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D15763
AFFECTED FILES
thumbnail/thumbnail.cpp
To: broulik, #frameworks, dfaure, anthonyfieroni, jtamate
Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp