D17205: Build kio_nfs against standalone libtirpc

[Andreas Sturmlechner]

asturmlechner created this revision.
asturmlechner added reviewers: Dolphin, dfaure, rdieter.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
asturmlechner requested review of this revision.

REVISION SUMMARY
Since glibc-2.26, cmake skipped over nfs when standalone tirpc
was installed in tirpc subdir (as done by Debian, Fedora, Arch, Gentoo...)

Use FindTIRPC and make kio_nfs optional that way
FindTIRPC taken from https://phabricator.kde.org/D12761

TEST PLAN
Built with libtirpc successfully.

REPOSITORY
R320 KIO Extras

BRANCH
kio_nfs

REVISION DETAIL
https://phabricator.kde.org/D17205

AFFECTED FILES
CMakeLists.txt
cmake/FindTIRPC.cmake
nfs/CMakeLists.txt

To: asturmlechner, #dolphin, dfaure, rdieter
Cc: kde-frameworks-devel, cgiboudeaux, arojas, kfm-devel, alexde, sourabhboss, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

[Harald Sitter]

sitter added a comment.


LGTM

I do wonder if we should support ntirpc too though. At a glance it's largely the same finder s/tirpc/ntirpc/. Admittedly I do not know why there are two libs and both seem to actively get commits.

INLINE COMMENTS

CMakeLists.txt:2
## Check for XDR functions
-include(CheckFunctionExists)
+include(CheckSymbolExists)

I think we need CheckCXXSymbolExists here. Since we use and link from C++, whether or not the symbols can be found and linked from C is of no importance.

CMakeLists.txt:15-26
if (HAVE_XDR_U_INT64_T)
add_definitions(-DHAVE_XDR_U_INT64_T)
endif (HAVE_XDR_U_INT64_T)
if (HAVE_XDR_UINT64_T)
add_definitions(-DHAVE_XDR_UINT64_T)
endif (HAVE_XDR_UINT64_T)
if (HAVE_XDR_U_HYPER)

As you are in the code already, maybe replace this abomination with a `configure_file`? 😉

REPOSITORY
R320 KIO Extras

REVISION DETAIL
https://phabricator.kde.org/D17205

To: asturmlechner, #dolphin, dfaure, rdieter
Cc: sitter, kde-frameworks-devel, cgiboudeaux, arojas, kfm-devel, alexde, sourabhboss, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov