D15255: Don't use QIcon::Selected state for selected icon

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Dolphin, VDG, elvisangelaccio, fvogt.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
broulik requested review of this revision.

REVISION SUMMARY
This causes selected monochrome Breeze icons to turn white as this state is meant for when the icon is actually painted ontop of e.g. a blue highlighted bar.
Since the advanced icon configuration (where you could choose a custom hint color and other effects) has been removed in Plasma 5.13 and more importantly the fact that Dolphin always tints the icon in the highlight color disregarding any custom icon effects settings this is an acceptable change.

TEST PLAN
Changed icon size to 16px, selected a folder, folder icon was still there. You can hardly see the blue tinting with the 1px outline icons, though
Before
F6233549: Screenshot_20180903_234454.png <https://phabricator.kde.org/F6233549>
After
F6233550: Screenshot_20180903_234531.png <https://phabricator.kde.org/F6233550>

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D15255

AFFECTED FILES
src/kitemviews/kstandarditemlistwidget.cpp

To: broulik, #dolphin, #vdg, elvisangelaccio, fvogt
Cc: kfm-devel, spoorun, navarromorales, firef, andrebarros, emmanuelp

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


Fixes 398014. Could we land this on the stable branch?

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D15255

To: broulik, #dolphin, #vdg, elvisangelaccio, fvogt, ngraham
Cc: ngraham, kfm-devel, spoorun, navarromorales, firef, andrebarros, emmanuelp

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D15255

To: broulik, #dolphin, #vdg, elvisangelaccio, fvogt, ngraham
Cc: ngraham, kfm-devel, spoorun, navarromorales, firef, andrebarros, emmanuelp

[Fabian Vogt]

fvogt accepted this revision.
fvogt added a comment.


I tried it - except for the not anymore disappearing icons I can't spot any difference.

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D15255

To: broulik, #dolphin, #vdg, elvisangelaccio, fvogt, ngraham
Cc: ngraham, kfm-devel, spoorun, navarromorales, firef, andrebarros, emmanuelp

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R318:b734386cbc84: Don&#039;t use QIcon::Selected state for selected icon (authored by broulik).

REPOSITORY
R318 Dolphin

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15255?vs=40944&id=40955

REVISION DETAIL
https://phabricator.kde.org/D15255

AFFECTED FILES
src/kitemviews/kstandarditemlistwidget.cpp

To: broulik, #dolphin, #vdg, elvisangelaccio, fvogt, ngraham
Cc: ngraham, kfm-devel, spoorun, navarromorales, firef, andrebarros, emmanuelp