Discussion:
D16460: Don't enable two-clicks renaming in single-click mode
Elvis Angelaccio
2018-10-27 14:58:33 UTC
Permalink
elvisangelaccio created this revision.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
elvisangelaccio requested review of this revision.

REVISION SUMMARY
This was supposed to be part of commit 5454283008f2 <https://phabricator.kde.org/R318:5454283008f26d377a6403861a3cdd7992dbbd38>, but apparently we
didn't notice it was missing.

TEST PLAN
- Enable single-click mode from system settings
- Select a file in dolphin
- Long-click the selected file and make sure inline renaming doesn't start

REPOSITORY
R318 Dolphin

BRANCH
Applications/18.08

REVISION DETAIL
https://phabricator.kde.org/D16460

AFFECTED FILES
src/views/dolphinview.cpp

To: elvisangelaccio
Cc: kfm-devel, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
Elvis Angelaccio
2018-10-27 14:58:56 UTC
Permalink
elvisangelaccio added reviewers: Dolphin, akrutzler, wbauer.

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D16460

To: elvisangelaccio, #dolphin, akrutzler, wbauer
Cc: kfm-devel, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
Nathaniel Graham
2018-10-27 15:13:14 UTC
Permalink
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
R318 Dolphin

BRANCH
Applications/18.08

REVISION DETAIL
https://phabricator.kde.org/D16460

To: elvisangelaccio, #dolphin, akrutzler, wbauer, ngraham
Cc: kfm-devel, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
Andreas Krutzler
2018-10-27 15:49:26 UTC
Permalink
akrutzler accepted this revision.

REPOSITORY
R318 Dolphin

BRANCH
Applications/18.08

REVISION DETAIL
https://phabricator.kde.org/D16460

To: elvisangelaccio, #dolphin, akrutzler, wbauer, ngraham
Cc: kfm-devel, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
Elvis Angelaccio
2018-10-27 16:03:55 UTC
Permalink
This revision was automatically updated to reflect the committed changes.
Closed by commit R318:e26ee6455e40: Don&#039;t enable two-clicks renaming in single-click mode (authored by elvisangelaccio).

REPOSITORY
R318 Dolphin

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16460?vs=44310&id=44314

REVISION DETAIL
https://phabricator.kde.org/D16460

AFFECTED FILES
src/views/dolphinview.cpp

To: elvisangelaccio, #dolphin, akrutzler, wbauer, ngraham
Cc: kfm-devel, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
Loading...