Discussion:
D16387: [sftp] put request chunk debugging into own category
Harald Sitter
2018-10-23 14:28:03 UTC
Permalink
sitter created this revision.
sitter added reviewers: asn, broulik, ngraham.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
it's excessively verbose and not necessarily useful unless one is actually
debugging request handling, so separating this from the general slave
debugging seems handy as one can enable one without the other.

CCBUG: 368877

TEST PLAN
builds, installs, has separate logging categories

REPOSITORY
R320 KIO Extras

BRANCH
sftp-trace-level

REVISION DETAIL
https://phabricator.kde.org/D16387

AFFECTED FILES
sftp/CMakeLists.txt
sftp/kio_sftp.cpp

To: sitter, asn, broulik, ngraham
Cc: kde-frameworks-devel, kfm-devel, sourabhboss, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp
Andreas Schneider
2018-10-23 14:32:20 UTC
Permalink
asn added a comment.


LGTM

REPOSITORY
R320 KIO Extras

REVISION DETAIL
https://phabricator.kde.org/D16387

To: sitter, asn, broulik, ngraham
Cc: kde-frameworks-devel, kfm-devel, sourabhboss, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp
Kai Uwe Broulik
2018-10-23 15:12:41 UTC
Permalink
broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
R320 KIO Extras

BRANCH
sftp-trace-level

REVISION DETAIL
https://phabricator.kde.org/D16387

To: sitter, asn, broulik, ngraham
Cc: kde-frameworks-devel, kfm-devel, sourabhboss, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp
Harald Sitter
2018-10-24 14:13:47 UTC
Permalink
This revision was automatically updated to reflect the committed changes.
Closed by commit R320:bf4563e8d291: [sftp] put request chunk debugging into own category (authored by sitter).

CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D16387?vs=44112&id=44153#toc

REPOSITORY
R320 KIO Extras

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16387?vs=44112&id=44153

REVISION DETAIL
https://phabricator.kde.org/D16387

AFFECTED FILES
sftp/CMakeLists.txt
sftp/kio_sftp.cpp

To: sitter, asn, broulik, ngraham
Cc: kde-frameworks-devel, kfm-devel, sourabhboss, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp
Loading...