Discussion:
D15938: Change icon for the 'Edit...' context menu entry in Places panel
Thomas Surrel
2018-10-04 07:32:02 UTC
Permalink
thsurrel created this revision.
thsurrel added reviewers: Dolphin, VDG, ngraham.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
thsurrel requested review of this revision.

REVISION SUMMARY
The current icon is used for displaying the Properties context menu
in other places in dolphin. Change to edit-entry.

TEST PLAN
Right-click on a place in the Places panel.

REPOSITORY
R318 Dolphin

BRANCH
arc_icon (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D15938

AFFECTED FILES
src/panels/places/placespanel.cpp

To: thsurrel, #dolphin, #vdg, ngraham
Cc: kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
Kai Uwe Broulik
2018-10-04 11:04:08 UTC
Permalink
broulik added a comment.


+1
This changes that "window" icon to the "edit pen"

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D15938

To: thsurrel, #dolphin, #vdg, ngraham
Cc: broulik, kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
Nathaniel Graham
2018-10-04 17:43:06 UTC
Permalink
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


+1, `document-properties` never made sense there.

REPOSITORY
R318 Dolphin

BRANCH
arc_icon (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D15938

To: thsurrel, #dolphin, #vdg, ngraham
Cc: broulik, kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
Nathaniel Graham
2018-10-04 17:45:20 UTC
Permalink
ngraham added a comment.


Landing now.

Can you make the same change for the KIO version too? It's in `<kio repo>/src/filewidgets/kfileplacesview.cpp`

REPOSITORY
R318 Dolphin

BRANCH
arc_icon (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D15938

To: thsurrel, #dolphin, #vdg, ngraham
Cc: broulik, kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
Nathaniel Graham
2018-10-04 17:52:51 UTC
Permalink
ngraham closed this revision.

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D15938

To: thsurrel, #dolphin, #vdg, ngraham
Cc: broulik, kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
Loading...