Discussion:
D15974: Add 'Mount' option to context menu of unmounted device in Places
Thomas Surrel
2018-10-05 20:49:31 UTC
Permalink
thsurrel created this revision.
thsurrel added reviewers: Dolphin, VDG.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
thsurrel requested review of this revision.

REPOSITORY
R318 Dolphin

BRANCH
arc_mount

REVISION DETAIL
https://phabricator.kde.org/D15974

AFFECTED FILES
src/panels/places/placesitemmodel.cpp
src/panels/places/placesitemmodel.h
src/panels/places/placespanel.cpp

To: thsurrel, #dolphin, #vdg
Cc: kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
Thomas Surrel
2018-10-05 20:50:55 UTC
Permalink
thsurrel added a comment.


This is only a proposal but:
1/ it the sysmetric of the Unmount entry in the context menu of mounted devices
2/ I have to admit it took me a very long time to discover (by accident) that you can just (left-)click on a unmounted device to get it mounted automatically. I might not be the only feeling that you should be able to mount a device from the context menu ...

As in D15929 <https://phabricator.kde.org/D15929>, I will do the twin commit in the kio code while dolphin places panel code is not based on kio.

F6306510: screenshot.png <https://phabricator.kde.org/F6306510>

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D15974

To: thsurrel, #dolphin, #vdg
Cc: kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
Andrew Crouthamel
2018-10-05 20:55:53 UTC
Permalink
acrouthamel added a comment.


Hey Thomas, just a note that you should put your initial comments and screenshot in the Details of the diff so it doesn't get lost after lengthy discussion.

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D15974

To: thsurrel, #dolphin, #vdg
Cc: acrouthamel, kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
Thomas Surrel
2018-10-05 20:57:30 UTC
Permalink
thsurrel edited the summary of this revision.

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D15974

To: thsurrel, #dolphin, #vdg
Cc: acrouthamel, kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
Thomas Surrel
2018-10-05 20:58:38 UTC
Permalink
thsurrel added a comment.


Point taken, thanks!

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D15974

To: thsurrel, #dolphin, #vdg
Cc: acrouthamel, kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
Andrew Crouthamel
2018-10-05 21:00:48 UTC
Permalink
acrouthamel added a comment.


+1 btw from me, makes sense and the context menu isn't very cluttered.

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D15974

To: thsurrel, #dolphin, #vdg
Cc: acrouthamel, kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
Thomas Surrel
2018-10-06 19:25:51 UTC
Permalink
thsurrel updated this revision to Diff 42980.
thsurrel added a comment.


Use existing requestStorageSetup method

REPOSITORY
R318 Dolphin

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15974?vs=42948&id=42980

BRANCH
arc_mount

REVISION DETAIL
https://phabricator.kde.org/D15974

AFFECTED FILES
src/panels/places/placespanel.cpp

To: thsurrel, #dolphin, #vdg
Cc: acrouthamel, kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
Thomas Surrel
2018-10-06 19:27:35 UTC
Permalink
thsurrel edited the summary of this revision.

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D15974

To: thsurrel, #dolphin, #vdg
Cc: acrouthamel, kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
Nathaniel Graham
2018-10-06 23:29:54 UTC
Permalink
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


I think this makes sense. Awesome work lately, Thomas.

REPOSITORY
R318 Dolphin

BRANCH
arc_mount

REVISION DETAIL
https://phabricator.kde.org/D15974

To: thsurrel, #dolphin, #vdg, ngraham
Cc: ngraham, acrouthamel, kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
Elvis Angelaccio
2018-10-07 09:13:47 UTC
Permalink
elvisangelaccio accepted this revision.

REPOSITORY
R318 Dolphin

BRANCH
arc_mount

REVISION DETAIL
https://phabricator.kde.org/D15974

To: thsurrel, #dolphin, #vdg, ngraham, elvisangelaccio
Cc: ngraham, acrouthamel, kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
Thomas Surrel
2018-10-07 13:31:58 UTC
Permalink
This revision was automatically updated to reflect the committed changes.
Closed by commit R318:467df92fb9f2: Add &#039;Mount&#039; option to context menu of unmounted device in Places (authored by thsurrel).

REPOSITORY
R318 Dolphin

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15974?vs=42980&id=43036

REVISION DETAIL
https://phabricator.kde.org/D15974

AFFECTED FILES
src/panels/places/placespanel.cpp

To: thsurrel, #dolphin, #vdg, ngraham, elvisangelaccio
Cc: ngraham, acrouthamel, kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
Loading...