Discussion:
D16272: apply eexist workaround from listDir to stat as well
Harald Sitter
2018-10-17 14:17:38 UTC
Permalink
sitter created this revision.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
knetattach stats() without first doing a listDir() so in the event that
the url requires authentication it won't work and error out on the EEXISTS.
listDir has a fallback hack for this which was missing from stat.

stat now has this workaround as well and correctly brings up an auth
dialog on shares that require it.

BUG: 399699

REPOSITORY
R320 KIO Extras

BRANCH
Applications/18.08

REVISION DETAIL
https://phabricator.kde.org/D16272

AFFECTED FILES
smb/kio_smb_browse.cpp

To: sitter
Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp
Harald Sitter
2018-10-17 14:18:26 UTC
Permalink
sitter edited the test plan for this revision.
sitter added a reviewer: broulik.

REPOSITORY
R320 KIO Extras

REVISION DETAIL
https://phabricator.kde.org/D16272

To: sitter, broulik
Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp
Kai Uwe Broulik
2018-10-17 14:28:50 UTC
Permalink
broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
R320 KIO Extras

BRANCH
Applications/18.08

REVISION DETAIL
https://phabricator.kde.org/D16272

To: sitter, broulik
Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp
Harald Sitter
2018-10-17 14:31:04 UTC
Permalink
This revision was automatically updated to reflect the committed changes.
Closed by commit R320:cf34ba609dc4: apply eexist workaround from listDir to stat as well (authored by sitter).

REPOSITORY
R320 KIO Extras

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16272?vs=43793&id=43795

REVISION DETAIL
https://phabricator.kde.org/D16272

AFFECTED FILES
smb/kio_smb_browse.cpp

To: sitter, broulik
Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp
Loading...