D15332: Use the more common string "Edit" in place of "Change"

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Dolphin, VDG.
Herald added a project: Baloo.
Herald added a subscriber: Baloo.
ngraham requested review of this revision.

REVISION SUMMARY
"Edit" is a more common string than "Change", so let's use that instead.

BUG: 398309
FIXED-IN: 18.12.0

TEST PLAN
[image goes here]

REPOSITORY
R824 Baloo Widgets

BRANCH
edit-instead-of-change (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D15332

AFFECTED FILES
src/kcommentwidget.cpp
src/tagwidget.cpp

To: ngraham, #dolphin, #vdg
Cc: #baloo, ashaposhnikov, astippich, spoorun, abrahams

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
R824 Baloo Widgets

REVISION DETAIL
https://phabricator.kde.org/D15332

To: ngraham, #dolphin, #vdg
Cc: #baloo, ashaposhnikov, astippich, spoorun, abrahams

[Kai Uwe Broulik]

broulik added a comment.


The window title for the tag editor should also be changed from "Change Tags" to "Edit Tags"

REPOSITORY
R824 Baloo Widgets

REVISION DETAIL
https://phabricator.kde.org/D15332

To: ngraham, #dolphin, #vdg
Cc: broulik, #baloo, ashaposhnikov, astippich, spoorun, abrahams

[Andres Betts]

abetts added a comment.


+1

REPOSITORY
R824 Baloo Widgets

REVISION DETAIL
https://phabricator.kde.org/D15332

To: ngraham, #dolphin, #vdg
Cc: abetts, broulik, #baloo, ashaposhnikov, astippich, spoorun, abrahams

[Stefan Brüns]

bruns added a comment.


As @broulik said, otherwise +1

REPOSITORY
R824 Baloo Widgets

REVISION DETAIL
https://phabricator.kde.org/D15332

To: ngraham, #dolphin, #vdg
Cc: bruns, abetts, broulik, #baloo, ashaposhnikov, astippich, spoorun, abrahams

[Nathaniel Graham]

ngraham updated this revision to Diff 41184.
ngraham added a comment.


Also change dialog titles

REPOSITORY
R824 Baloo Widgets

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15332?vs=41156&id=41184

BRANCH
edit-instead-of-change (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D15332

AFFECTED FILES
src/kcommentwidget.cpp
src/kedittagsdialog.cpp
src/tagwidget.cpp

To: ngraham, #dolphin, #vdg
Cc: bruns, abetts, broulik, #baloo, ashaposhnikov, astippich, spoorun, abrahams

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
R824 Baloo Widgets

BRANCH
edit-instead-of-change (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D15332

To: ngraham, #dolphin, #vdg, broulik
Cc: bruns, abetts, broulik, #baloo, ashaposhnikov, astippich, spoorun, abrahams

[Nathaniel Graham]

ngraham closed this revision.

REPOSITORY
R824 Baloo Widgets

REVISION DETAIL
https://phabricator.kde.org/D15332

To: ngraham, #dolphin, #vdg, broulik
Cc: bruns, abetts, broulik, #baloo, ashaposhnikov, astippich, spoorun, abrahams