Discussion:
D15114: Renames DolphinViewContainer::getCaption to caption
David Hallas
2018-08-28 07:52:15 UTC
Permalink
hallas created this revision.
hallas added a reviewer: elvisangelaccio.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
hallas requested review of this revision.

REVISION SUMMARY
This commit renames the DolphinViewContainer::getCaption to simply
caption, this was a review comment that I failed to fix in a previous
commit.

TEST PLAN
None

REPOSITORY
R318 Dolphin

BRANCH
master

REVISION DETAIL
https://phabricator.kde.org/D15114

AFFECTED FILES
src/dolphinmainwindow.cpp
src/dolphintabwidget.cpp
src/dolphinviewcontainer.cpp
src/dolphinviewcontainer.h

To: hallas, elvisangelaccio
Cc: kfm-devel, spoorun, navarromorales, firef, andrebarros, emmanuelp
Elvis Angelaccio
2018-09-02 08:57:40 UTC
Permalink
elvisangelaccio accepted this revision.
elvisangelaccio added a comment.
This revision is now accepted and ready to land.


Thanks

REPOSITORY
R318 Dolphin

BRANCH
master

REVISION DETAIL
https://phabricator.kde.org/D15114

To: hallas, elvisangelaccio
Cc: kfm-devel, spoorun, navarromorales, firef, andrebarros, emmanuelp
David Hallas
2018-09-02 09:10:39 UTC
Permalink
hallas updated this revision to Diff 40848.
hallas added a comment.


Rebased on master

REPOSITORY
R318 Dolphin

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15114?vs=40537&id=40848

BRANCH
renames_getCaption_to_caption (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D15114

AFFECTED FILES
src/dolphinmainwindow.cpp
src/dolphintabwidget.cpp
src/dolphinviewcontainer.cpp
src/dolphinviewcontainer.h

To: hallas, elvisangelaccio
Cc: kfm-devel, spoorun, navarromorales, firef, andrebarros, emmanuelp
Elvis Angelaccio
2018-09-02 09:10:55 UTC
Permalink
elvisangelaccio accepted this revision.

REPOSITORY
R318 Dolphin

BRANCH
renames_getCaption_to_caption (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D15114

To: hallas, elvisangelaccio
Cc: kfm-devel, spoorun, navarromorales, firef, andrebarros, emmanuelp
David Hallas
2018-09-02 09:11:46 UTC
Permalink
hallas closed this revision.

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D15114

To: hallas, elvisangelaccio
Cc: kfm-devel, spoorun, navarromorales, firef, andrebarros, emmanuelp
Loading...