D15371: Don't assign twice the same key to the action New Tab

[Jaime Torres Amate]

jtamate created this revision.
jtamate added a reviewer: Dolphin.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
jtamate requested review of this revision.

REVISION SUMMARY
QKeySequence::AddTab = Qt::CTRL + Qt::Key_T.
Leaving only the first avoids the warning window "There are two actions (New Tab, New Tab) that want to use the same shortcut (Ctrl+T)"

BUG: 398324

TEST PLAN
su - test
unset KDE_FULL_SESSION
dolphin
After: No more the warning window.

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D15371

AFFECTED FILES
src/dolphinmainwindow.cpp

To: jtamate, #dolphin
Cc: kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp

[Elvis Angelaccio]

elvisangelaccio accepted this revision.
elvisangelaccio added a comment.
This revision is now accepted and ready to land.


Stable branch, please. Thanks!

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D15371

To: jtamate, #dolphin, elvisangelaccio
Cc: elvisangelaccio, kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp

[Jaime Torres Amate]

This revision was automatically updated to reflect the committed changes.
Closed by commit R318:9991eb0f5eaf: Don't assign twice the same key to the action New Tab (authored by jtamate).

REPOSITORY
R318 Dolphin

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15371?vs=41250&id=41345

REVISION DETAIL
https://phabricator.kde.org/D15371

AFFECTED FILES
src/dolphinmainwindow.cpp

To: jtamate, #dolphin, elvisangelaccio
Cc: elvisangelaccio, kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp

[Nathaniel Graham]

ngraham reopened this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


This broke the Ctrl T keyboard shortcut. Can we please fix it?

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D15371

To: jtamate, #dolphin, elvisangelaccio
Cc: ngraham, elvisangelaccio, kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp

[Jaime Torres Amate]

jtamate updated this revision to Diff 42924.
jtamate added a comment.


As it turns out, QKeySequence::AddTab is Ctrl+Shift+N under plasma.
Filled Qt bug: https://bugreports.qt.io/browse/QTBUG-70963
Change to Qt::CTRL + Qt::Key_T.

REPOSITORY
R318 Dolphin

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15371?vs=41345&id=42924

REVISION DETAIL
https://phabricator.kde.org/D15371

AFFECTED FILES
src/dolphinmainwindow.cpp

To: jtamate, #dolphin, elvisangelaccio
Cc: ngraham, elvisangelaccio, kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp

[Jaime Torres Amate]

jtamate updated this revision to Diff 42928.
jtamate edited the test plan for this revision.
jtamate added a comment.


Keep both key sequences in case someone used ctrl+shift+n.

REPOSITORY
R318 Dolphin

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15371?vs=42924&id=42928

REVISION DETAIL
https://phabricator.kde.org/D15371

AFFECTED FILES
src/dolphinmainwindow.cpp

To: jtamate, #dolphin, elvisangelaccio
Cc: ngraham, elvisangelaccio, kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


Much better, thanks. Please commit to the stable branch and merge to master, since the original commit went into the stable branch and we don't want it to stay broken there.

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D15371

To: jtamate, #dolphin, elvisangelaccio, ngraham
Cc: ngraham, elvisangelaccio, kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp

[Elvis Angelaccio]

elvisangelaccio added a comment.


I don't get it. [Ctrl] + [T] works with dolphin from my arch distro package. It doesn't work with my self-compiled dolphin though. What's going on?

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D15371

To: jtamate, #dolphin, elvisangelaccio, ngraham
Cc: ngraham, elvisangelaccio, kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp

[Jaime Torres Amate]

jtamate closed this revision.
jtamate added a comment.


closed again by commits:
https://commits.kde.org/dolphin/5d180c5bb280f68cb98996044055e6891e29bab7
https://commits.kde.org/dolphin/b610ce5913ef3172f3cf15c0a1d93c255ea0da4f

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D15371

To: jtamate, #dolphin, elvisangelaccio, ngraham
Cc: ngraham, elvisangelaccio, kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp