D15904: Fix that dragging a file can trigger inline rename.

[Andreas Krutzler]

akrutzler created this revision.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
akrutzler requested review of this revision.

REVISION SUMMARY
Inline renaming is aborted as soon as an item is dragged. Previously, ’m_dragging' was used to determine if an item was being dragged. However, inline renaming is triggered after a certain amount of
time, during which time the user may have stopped dragging items.

BUG: 398375
FIXED-IN: 18.08.2

TEST PLAN
When dragging an selected item, inline renaming should never be started, regardless of where you drag it (Places panel, other split-view window, out of the Dolphin window, ...).

REPOSITORY
R318 Dolphin

BRANCH
fix_drag_file_trigger_inline_renaming (branched from Applications/18.08)

REVISION DETAIL
https://phabricator.kde.org/D15904

AFFECTED FILES
src/views/dolphinview.cpp

To: akrutzler
Cc: kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp

[Andreas Krutzler]

akrutzler added reviewers: wbauer, elvisangelaccio.

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D15904

To: akrutzler, wbauer, elvisangelaccio
Cc: kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp

[Nathaniel Graham]

ngraham added a reviewer: Dolphin.

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D15904

To: akrutzler, wbauer, elvisangelaccio, #dolphin
Cc: kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp

[Elvis Angelaccio]

elvisangelaccio accepted this revision as: elvisangelaccio.
elvisangelaccio added a comment.
This revision is now accepted and ready to land.


Thanks!

REPOSITORY
R318 Dolphin

BRANCH
fix_drag_file_trigger_inline_renaming (branched from Applications/18.08)

REVISION DETAIL
https://phabricator.kde.org/D15904

To: akrutzler, wbauer, elvisangelaccio, #dolphin
Cc: kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp

[Nathaniel Graham]

ngraham accepted this revision.

REPOSITORY
R318 Dolphin

BRANCH
fix_drag_file_trigger_inline_renaming (branched from Applications/18.08)

REVISION DETAIL
https://phabricator.kde.org/D15904

To: akrutzler, wbauer, elvisangelaccio, #dolphin, ngraham
Cc: kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp

[Wolfgang Bauer]

wbauer accepted this revision.
wbauer added a comment.


The patch seems to work fine, I was not able to trigger inline rename by dragging a file anymore.
Thank you!

REPOSITORY
R318 Dolphin

BRANCH
fix_drag_file_trigger_inline_renaming (branched from Applications/18.08)

REVISION DETAIL
https://phabricator.kde.org/D15904

To: akrutzler, wbauer, elvisangelaccio, #dolphin, ngraham
Cc: kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp

[Andreas Krutzler]

This revision was automatically updated to reflect the committed changes.
Closed by commit R318:ddfc86ab8c20: Fix that dragging a file can trigger inline rename. (authored by akrutzler).

REPOSITORY
R318 Dolphin

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15904?vs=42747&id=42809

REVISION DETAIL
https://phabricator.kde.org/D15904

AFFECTED FILES
src/views/dolphinview.cpp

To: akrutzler, wbauer, elvisangelaccio, #dolphin, ngraham
Cc: kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp

[Andreas Krutzler]

akrutzler added a comment.


Should I merge `Applications/18.08` into `master` too?

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D15904

To: akrutzler, wbauer, elvisangelaccio, #dolphin, ngraham
Cc: kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp

[Nathaniel Graham]

ngraham added a comment.


Yes please!

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D15904

To: akrutzler, wbauer, elvisangelaccio, #dolphin, ngraham
Cc: kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp