D16653: Use the new `drive-harddisk-root` icon for the root volume

Discussion:

Nathaniel Graham

2018-11-03 22:26:52 UTC

ngraham created this revision.
ngraham added reviewers: romangg, VDG, Dolphin, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
Use the new `drive-harddisk-root` icon to mark the root volume. This makes it obvious which disk corresponds to `/` when there are multiple disks, and allows us to remove the root entry from the top section of the Places panel

Depends on D16633 <https://phabricator.kde.org/D16633>

TEST PLAN
[images go here]

REPOSITORY
R245 Solid

BRANCH
root-disk-icon (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D16653

AFFECTED FILES
src/solid/devices/backends/udisks2/udisksdevice.cpp

To: ngraham, romangg, #vdg, #dolphin, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Nathaniel Graham

2018-11-03 22:27:12 UTC

Permalink

ngraham added a task: T8349: Improve Places panel usability and presentation.

REPOSITORY
R245 Solid

REVISION DETAIL
https://phabricator.kde.org/D16653

To: ngraham, romangg, #vdg, #dolphin, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Nathaniel Graham

2018-11-03 22:31:01 UTC

Permalink

ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
R245 Solid

REVISION DETAIL
https://phabricator.kde.org/D16653

To: ngraham, romangg, #vdg, #dolphin, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Nathaniel Graham

2018-11-03 22:31:32 UTC

Permalink

ngraham added a dependent revision: D15739: [Places panel] Don't show Root by default.

REPOSITORY
R245 Solid

REVISION DETAIL
https://phabricator.kde.org/D16653

To: ngraham, romangg, #vdg, #dolphin, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Nathaniel Graham

2018-11-03 22:33:48 UTC

Permalink

ngraham added a reviewer: bruns.

REPOSITORY
R245 Solid

REVISION DETAIL
https://phabricator.kde.org/D16653

To: ngraham, romangg, #vdg, #dolphin, #frameworks, bruns
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Stefan Brüns

2018-11-04 22:22:17 UTC

Permalink

bruns added inline comments.

INLINE COMMENTS

udisksdevice.cpp:619
+ const UDisks2::StorageAccess accessIface(const_cast<Device *>(this));
+ if (accessIface.filePath() == "/") {
+ return "drive-harddisk-root";

QLatin1String

udisksdevice.cpp:620
+ if (accessIface.filePath() == "/") {
+ return "drive-harddisk-root";
+ }

QStringLiteral

REPOSITORY
R245 Solid

REVISION DETAIL
https://phabricator.kde.org/D16653

To: ngraham, romangg, #vdg, #dolphin, #frameworks, bruns
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Nathaniel Graham

2018-11-04 22:27:01 UTC

Permalink

ngraham updated this revision to Diff 44871.
ngraham marked 2 inline comments as done.
ngraham added a comment.

Fix embarrassing errors

REPOSITORY
R245 Solid

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16653?vs=44808&id=44871

BRANCH
arcpatch-D16653

REVISION DETAIL
https://phabricator.kde.org/D16653

AFFECTED FILES
src/solid/devices/backends/udisks2/udisksdevice.cpp

To: ngraham, romangg, #vdg, #dolphin, #frameworks, bruns
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Stefan Brüns

2018-11-04 22:28:18 UTC

Permalink

bruns accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
R245 Solid

BRANCH
arcpatch-D16653

REVISION DETAIL
https://phabricator.kde.org/D16653

To: ngraham, romangg, #vdg, #dolphin, #frameworks, bruns
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Andres Betts

2018-11-04 22:48:59 UTC

Permalink

abetts accepted this revision.
abetts added a comment.

Minor detail with great impact. Thank you for the work.

REPOSITORY
R245 Solid

BRANCH
arcpatch-D16653

REVISION DETAIL
https://phabricator.kde.org/D16653

To: ngraham, romangg, #vdg, #dolphin, #frameworks, bruns, abetts
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

Nathaniel Graham

2018-11-04 22:59:22 UTC

Permalink

This revision was automatically updated to reflect the committed changes.
Closed by commit R245:b34d13cb1861: Use the new `drive-harddisk-root` icon for the root volume (authored by ngraham).

REPOSITORY
R245 Solid

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16653?vs=44871&id=44875

REVISION DETAIL
https://phabricator.kde.org/D16653

AFFECTED FILES
src/solid/devices/backends/udisks2/udisksdevice.cpp

To: ngraham, romangg, #vdg, #dolphin, #frameworks, bruns, abetts
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

Nathaniel Graham

2018-11-05 04:09:31 UTC

Permalink

ngraham added a comment.

This broke icons for other things; currently investigating and will fix ASAP.

REPOSITORY
R245 Solid

REVISION DETAIL
https://phabricator.kde.org/D16653

To: ngraham, romangg, #vdg, #dolphin, #frameworks, bruns, abetts
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

Nathaniel Graham

2018-11-05 04:49:23 UTC

Permalink

ngraham added a comment.

Hopefully this should fix it: D16678 <https://phabricator.kde.org/D16678>

REPOSITORY
R245 Solid

REVISION DETAIL
https://phabricator.kde.org/D16653

To: ngraham, romangg, #vdg, #dolphin, #frameworks, bruns, abetts
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns