D16529: make libssh module default to the "new" libssh config by default

[Harald Sitter]

sitter created this revision.
sitter added reviewers: broulik, asn.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
- rename module from LibSSH to libssh so casing is consistent with config
- module now quietly attempts to find libssh by config and returns if found
- if it was not found we'll fall back to manual lookup
- adjust actual FOUND variable use for correct case
- fix package case in properties set up (this is case sensitive)

this is singularly necessary because the config file is not correctly
packaged in ubuntu 18.04 (LTS)

https://bugs.launchpad.net/ubuntu/+source/libssh/+bug/1800135/comments/2

This reverts 3b1fd6bd8866da2dadd33705af53613236503efc <https://phabricator.kde.org/R320:3b1fd6bd8866da2dadd33705af53613236503efc>.

BUG: 400291

TEST PLAN
builds in ubuntu docker container and with a system that has a proper config

REPOSITORY
R320 KIO Extras

BRANCH
master

REVISION DETAIL
https://phabricator.kde.org/D16529

AFFECTED FILES
CMakeLists.txt
cmake/Findlibssh.cmake

To: sitter, broulik, asn
Cc: kde-frameworks-devel, kfm-devel, alexde, sourabhboss, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
R320 KIO Extras

BRANCH
master

REVISION DETAIL
https://phabricator.kde.org/D16529

To: sitter, broulik, asn
Cc: kde-frameworks-devel, kfm-devel, alexde, sourabhboss, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:0e129b10ae30: make libssh module default to the &quot;new&quot; libssh config by default (authored by sitter).

REPOSITORY
R320 KIO Extras

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16529?vs=44496&id=44531

REVISION DETAIL
https://phabricator.kde.org/D16529

AFFECTED FILES
CMakeLists.txt
cmake/Findlibssh.cmake

To: sitter, broulik, asn
Cc: kde-frameworks-devel, kfm-devel, alexde, sourabhboss, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp