D15404: [KFileItemModelRolesUpdater] Avoid duplicate indexes to resolve

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Dolphin, elvisangelaccio.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
broulik requested review of this revision.

REVISION SUMMARY
This avoids requesting a thumbnail twice for certain files, typically the first or last one in a folder

TEST PLAN
Noticed that it would generate the thumbnail for the first folder twice

Haven't spotted any more duplicates, there could be more cases

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D15404

AFFECTED FILES
src/kitemviews/kfileitemmodelrolesupdater.cpp

To: broulik, #dolphin, elvisangelaccio
Cc: kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp

[Eike Hein]

hein accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D15404

To: broulik, #dolphin, elvisangelaccio, hein
Cc: kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R318:033eb6b3a35c: [KFileItemModelRolesUpdater] Avoid duplicate indexes to resolve (authored by broulik).

REPOSITORY
R318 Dolphin

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15404?vs=41340&id=41378

REVISION DETAIL
https://phabricator.kde.org/D15404

AFFECTED FILES
src/kitemviews/kfileitemmodelrolesupdater.cpp

To: broulik, #dolphin, elvisangelaccio, hein
Cc: kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp

[Kai Uwe Broulik]

broulik reopened this revision.
broulik added a comment.
This revision is now accepted and ready to land.


I just reverted it, when I open Dolphin directly into a folder with few files, it doesn't load the first thumbnail anymore now :/

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D15404

To: broulik, #dolphin, elvisangelaccio, hein
Cc: kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

kfileitemmodelrolesupdater.cpp:1141
QList<int> result;
result.reserve(ResolveAllItemsLimit);

Make it this set and return toList ?

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D15404

To: broulik, #dolphin, elvisangelaccio, hein
Cc: anthonyfieroni, kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

anthonyfieroni wrote in kfileitemmodelrolesupdater.cpp:1141
Make it this set and return toList ?

I thought about the same but the order in which the previews are generated does matter

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D15404

To: broulik, #dolphin, elvisangelaccio, hein
Cc: anthonyfieroni, kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp

[Elvis Angelaccio]

elvisangelaccio added a comment.


@broulik Can you please "plan changes" or abandon it then?

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D15404

To: broulik, #dolphin, elvisangelaccio, hein
Cc: anthonyfieroni, kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp

[Kai Uwe Broulik]

broulik abandoned this revision.
broulik added a comment.


Needs some more thorough investigation

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D15404

To: broulik, #dolphin, elvisangelaccio, hein
Cc: anthonyfieroni, kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp