D15774: Track search mode in variable

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Dolphin, elvisangelaccio, ngraham.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
broulik requested review of this revision.

REVISION SUMMARY
Rather than relying on a widget being visible which might not be the case for e.g. non-active tabs

TEST PLAN
Noticed while testing D15772 <https://phabricator.kde.org/D15772> that when in a search, pressing Ctrl+T that would open the same search in a new tab would show the url instead because by the time the tab is added and its title evaluated the search box might not have been polished/made visible

- Ctrl+F → type something → Ctrl+T → now the tab title is correct

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D15774

AFFECTED FILES
src/dolphinviewcontainer.cpp
src/dolphinviewcontainer.h

To: broulik, #dolphin, elvisangelaccio, ngraham
Cc: kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp

[Nathaniel Graham]

ngraham added a dependency: D15772: Fix window / tab caption in search mode.

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D15774

To: broulik, #dolphin, elvisangelaccio, ngraham
Cc: kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


Requires D15772 <https://phabricator.kde.org/D15772> to see the fix, but yeah, this fixes it!

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D15774

To: broulik, #dolphin, elvisangelaccio, ngraham
Cc: kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R318:be077d3a0cde: Track search mode in variable (authored by broulik).

REPOSITORY
R318 Dolphin

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15774?vs=42373&id=42417

REVISION DETAIL
https://phabricator.kde.org/D15774

AFFECTED FILES
src/dolphinviewcontainer.cpp
src/dolphinviewcontainer.h

To: broulik, #dolphin, elvisangelaccio, ngraham
Cc: kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp