D7014: closing split view closes the currently focused view instead of the inactive

[Oleg Solovyov]

McPain updated this revision to Diff 17419.
McPain retitled this revision from "Middle click on QSystemTrayIcon сauses context menu " to "closing split view closes the currently focused view instead of the inactive".
McPain edited the summary of this revision.
McPain added a reviewer: Dolphin.
McPain changed the repository for this revision from R135 Integration for Qt applications in Plasma to R318 Dolphin.
McPain edited projects, added Dolphin; removed Plasma.
McPain edited subscribers, added: Dolphin; removed: plasma-devel.
Restricted Application added a subscriber: Konqueror.

REPOSITORY
R318 Dolphin

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7014?vs=17417&id=17419

REVISION DETAIL
https://phabricator.kde.org/D7014

AFFECTED FILES
src/dolphinmainwindow.cpp
src/dolphintabpage.cpp

To: McPain, #dolphin
Cc: #konqueror, #dolphin, firef, andrebarros, emmanuelp

[Oleg Solovyov]

McPain added a reviewer: elvisangelaccio.

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D7014

To: McPain, #dolphin, elvisangelaccio
Cc: #konqueror, #dolphin, firef, andrebarros, emmanuelp

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.


This is the intended behavior.
What we could do is adding another action that closes the inactive view. Feel free to submit a patch with unit tests in `src/tests/dolphinmainwindowtest.cpp`.

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D7014

To: McPain, #dolphin, elvisangelaccio
Cc: #konqueror, #dolphin, firef, andrebarros, emmanuelp

[Oleg Solovyov]

McPain updated this revision to Diff 17692.
McPain added a comment.


Dolphin splits actions if split view is enabled.
W/o autotestst yet

REPOSITORY
R318 Dolphin

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7014?vs=17419&id=17692

REVISION DETAIL
https://phabricator.kde.org/D7014

AFFECTED FILES
dolphin-17.04.3/src/dolphinmainwindow.cpp
dolphin-17.04.3/src/dolphintabpage.cpp
dolphin-17.04.3/src/dolphintabpage.h
dolphin-17.04.3/src/dolphinui.rc

To: McPain, #dolphin, elvisangelaccio
Cc: #konqueror, #dolphin, firef, andrebarros, emmanuelp

[Elvis Angelaccio]

elvisangelaccio added a comment.


Please rebase onto master branch, otherwise we can't apply the patch.

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D7014

To: McPain, #dolphin, elvisangelaccio
Cc: #konqueror, #dolphin, firef, andrebarros, emmanuelp

[Christoph Feck]

cfeck requested changes to this revision.
cfeck added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

dolphinmainwindow.cpp:545
tabPage->setSplitViewEnabled(false);
- tabPage->setSplitViewEnabled(true, QUrl("stash:/"));
+ tabPage->setSplitViewEnabled(true, true, QUrl("stash:/"));
}

https://ariya.io/2011/08/hall-of-api-shame-boolean-trap
https://wiki.qt.io/API_Design_Principles#The_Boolean_Parameter_Trap

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D7014

To: McPain, #dolphin, elvisangelaccio, cfeck
Cc: cfeck, #konqueror, #dolphin, firef, andrebarros, emmanuelp

[Oleg Solovyov]

McPain abandoned this revision.
Herald added a subscriber: kfm-devel.

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D7014

To: McPain, #dolphin, elvisangelaccio, cfeck
Cc: kfm-devel, cfeck, #konqueror, #dolphin, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp