D17063: Fix middle click on breadcrumbs, in split view

[Thomas Surrel]

thsurrel created this revision.
thsurrel added a reviewer: Dolphin.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
thsurrel requested review of this revision.

REVISION SUMMARY
Middle click on a folder in the breadcrumbs was ignored when
done one the 'not focused' part of a split view. It now opens
the folder in a new tab as expected.

BUG: 386453

TEST PLAN
Activate the split view. In the greyed out part of the split
view, press the middle mouse button on the breadcrumb.

REPOSITORY
R318 Dolphin

BRANCH
arc_breadcrumb (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D17063

AFFECTED FILES
src/dolphinmainwindow.cpp

To: thsurrel, #dolphin
Cc: kfm-devel, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.


Looks good beside the inline issue (hence why my Request Changes).

But I have another proposal: what if middle-clicking on the inactive urlnavigator would toggle the active split view?
We already do that if we middle-click the inactive view itself, or a folder in the inactive view.

Thoughts?

INLINE COMMENTS

dolphinmainwindow.cpp:974-975
if (oldViewContainer) {
// Disconnect all signals between the old view container (container,
// view and url navigator) and main window.
oldViewContainer->disconnect(this);

This comment should be updated too.

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D17063

To: thsurrel, #dolphin, elvisangelaccio
Cc: elvisangelaccio, kfm-devel, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov

[Thomas Surrel]

thsurrel added a comment.


That sounds better. I will give that a try as soon as I have some time.

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D17063

To: thsurrel, #dolphin, elvisangelaccio
Cc: elvisangelaccio, kfm-devel, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov

[Thomas Surrel]

thsurrel added a comment.


I tried a different approach for this in D17114 <https://phabricator.kde.org/D17114>

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D17063

To: thsurrel, #dolphin, elvisangelaccio
Cc: elvisangelaccio, kfm-devel, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov

[Elvis Angelaccio]

elvisangelaccio added a comment.


@thsurrel Don't forget to abandond this diff :)

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D17063

To: thsurrel, #dolphin, elvisangelaccio
Cc: elvisangelaccio, kfm-devel, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov

[Thomas Surrel]

thsurrel abandoned this revision.

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D17063

To: thsurrel, #dolphin, elvisangelaccio
Cc: elvisangelaccio, kfm-devel, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov