D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Dolphin, Gwenview, Frameworks, VDG.
Restricted Application added a project: Frameworks.
ngraham requested review of this revision.

REVISION SUMMARY
Remove the Recently Saved > This Month and Recently Saved > Last Month entries from the Places panel for new installs. This is for the following reasons:

1. "This Month" and "Last Month" aren't actually recent at all
2. The functionality of these two entries is very infrequently used, and doesn't deserve to be featured so prominently
3. This functionality is already available via the Find panel

This change improves the signal-to-noise ratio of the Places panel in the service of T8349: Improve Places panel usability and presentation <https://phabricator.kde.org/T8349>

TEST PLAN
Created a new user account, logged into it, and opened Dolphin:
[image goes here]

REPOSITORY
R241 KIO

BRANCH
remove-recently-saved-this-month-and-last-month (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D11767

AFFECTED FILES
src/filewidgets/kfileplacesmodel.cpp

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg
Cc: michaelh, ngraham

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
R241 KIO

REVISION DETAIL
https://phabricator.kde.org/D11767

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg
Cc: michaelh, ngraham

[Chris Rizzitello]

rizzitello added a comment.


Perhaps remove the yesterday entry and just show recently created with a link to timeline:/ ?

REPOSITORY
R241 KIO

REVISION DETAIL
https://phabricator.kde.org/D11767

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg
Cc: rizzitello, michaelh, ngraham

[Nathaniel Graham]

ngraham added a dependent revision: D11768: Add Desktop and Downloads to the default list of Places.

REPOSITORY
R241 KIO

REVISION DETAIL
https://phabricator.kde.org/D11767

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg
Cc: rizzitello, michaelh, ngraham

[Nathaniel Graham]

ngraham added a comment.


I think the two remaining entries are useful enough to warrant showing them both. `timeline:/` is too indirect, and requires at least one extra click to reach the "recently saved today" functionality.

REPOSITORY
R241 KIO

REVISION DETAIL
https://phabricator.kde.org/D11767

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg
Cc: rizzitello, michaelh, ngraham

[Andres Betts]

abetts added a comment.


Can we just call all of those entries just "Recent" or "Recently Used" independent of when it happened? I feel that would be more clear without having to remove the feature.

REPOSITORY
R241 KIO

REVISION DETAIL
https://phabricator.kde.org/D11767

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg
Cc: abetts, rizzitello, michaelh, ngraham

[Chris Rizzitello]

rizzitello added a comment.

Post by Andres Betts
Can we just call all of those entries just "Recent" or "Recently Used" independent of when it happened? I feel that would be more clear without having to remove the feature.

+1

REPOSITORY
R241 KIO

REVISION DETAIL
https://phabricator.kde.org/D11767

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg
Cc: abetts, rizzitello, michaelh, ngraham

[Nathaniel Graham]

ngraham added a comment.


We're not removing any features. This patch just removes Recently Saved > This Month and Recently Saved > Last Month from the default places panel. The feature is still available via the Find panel.

I //would// like to rename the feature to just be "Recently used" or "Recent documents" or something like that, but that requires code changes first to make the feature actually show different things, and would need to be covered in a different patch. This task is already tracked on T8349 <https://phabricator.kde.org/T8349>, FWIW.

REPOSITORY
R241 KIO

REVISION DETAIL
https://phabricator.kde.org/D11767

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg
Cc: abetts, rizzitello, michaelh, ngraham

[Nathaniel Graham]

ngraham added a comment.


Any more opinions on this patch? Is anyone particularly attached to these entries? Does anyone actually use them from the Places panel in the first place?

REPOSITORY
R241 KIO

REVISION DETAIL
https://phabricator.kde.org/D11767

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg
Cc: abetts, rizzitello, michaelh, ngraham

[Elvis Angelaccio]

elvisangelaccio added a comment.


+1

REPOSITORY
R241 KIO

REVISION DETAIL
https://phabricator.kde.org/D11767

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg
Cc: elvisangelaccio, abetts, rizzitello, michaelh, ngraham

[Scott Harvey]

sharvey added a comment.


+1. Don't use 'em, won't miss 'em.

REPOSITORY
R241 KIO

REVISION DETAIL
https://phabricator.kde.org/D11767

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg
Cc: sharvey, elvisangelaccio, abetts, rizzitello, michaelh, ngraham

[Nathaniel Graham]

ngraham added a comment.


Okay, unless I hear any impassioned pleas in favor of these entries, I will commit this patch on Saturday, April 7th.

REPOSITORY
R241 KIO

REVISION DETAIL
https://phabricator.kde.org/D11767

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg
Cc: sharvey, elvisangelaccio, abetts, rizzitello, michaelh, ngraham

[Michael Heidelbach]

michaelh added a comment.


Why is sum(+1) == +3 but noone accepted this? Is there social convention I miss?
(It's scaring me off from simply accepting this.)
+1

REPOSITORY
R241 KIO

REVISION DETAIL
https://phabricator.kde.org/D11767

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg
Cc: michaelh, sharvey, elvisangelaccio, abetts, rizzitello, ngraham

[Nathaniel Graham]

ngraham added a comment.


In general, people offer a +1 without formally accepting when they generally and vaguely approve, but not enough to:

- Care that much about it
- Want to put their formal stamp of approval on it for the purpose of blame if it breaks or proves unpopular

Let me announce that I'm willing to take all the heat from any potential issues, so feel free to offer formal acceptance, folks! :-)

REPOSITORY
R241 KIO

REVISION DETAIL
https://phabricator.kde.org/D11767

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg
Cc: michaelh, sharvey, elvisangelaccio, abetts, rizzitello, ngraham

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.

Post by Michael Heidelbach
Is there social convention I miss?

It comes from gerrit that most of us use for Qt.

https://gerrit-review.googlesource.com/Documentation/config-labels.html

REPOSITORY
R241 KIO

BRANCH
remove-recently-saved-this-month-and-last-month (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D11767

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, davidedmundson
Cc: davidedmundson, michaelh, sharvey, elvisangelaccio, abetts, rizzitello, ngraham

[Michael Heidelbach]

michaelh added a comment.

Post by Nathaniel Graham
Let me announce that I'm willing to take all the heat from any potential issues, so feel free to offer formal acceptance, folks! :-)

Can I have this as a signature?

Post by Nathaniel Graham
It comes from gerrit that most of us use for Qt.
https://gerrit-review.googlesource.com/Documentation/config-labels.html

Ah... that clarifies quite a bit, thanks.

REPOSITORY
R241 KIO

BRANCH
remove-recently-saved-this-month-and-last-month (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D11767

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, davidedmundson
Cc: davidedmundson, michaelh, sharvey, elvisangelaccio, abetts, rizzitello, ngraham

[Nathaniel Graham]

ngraham added a comment.


Thanks folks.

REPOSITORY
R241 KIO

BRANCH
remove-recently-saved-this-month-and-last-month (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D11767

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, davidedmundson
Cc: davidedmundson, michaelh, sharvey, elvisangelaccio, abetts, rizzitello, ngraham

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:7e1d2fb84546: Remove Recently Saved This Month and Recently Saved Last Month entries by
 (authored by ngraham).

CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D11767?vs=30798&id=31340#toc

REPOSITORY
R241 KIO

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11767?vs=30798&id=31340

REVISION DETAIL
https://phabricator.kde.org/D11767

AFFECTED FILES
src/filewidgets/kfileplacesmodel.cpp

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, davidedmundson
Cc: davidedmundson, michaelh, sharvey, elvisangelaccio, abetts, rizzitello, ngraham

[Henrik Fehlauer]

rkflx added a comment.

Post by Nathaniel Graham
Okay, unless I hear any impassioned pleas in favor of these entries, I will commit this patch on Saturday, April 7th.

Huh?

REPOSITORY
R241 KIO

REVISION DETAIL
https://phabricator.kde.org/D11767

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, davidedmundson
Cc: rkflx, davidedmundson, michaelh, sharvey, elvisangelaccio, abetts, rizzitello, ngraham

[Nathaniel Graham]

ngraham added a comment.


That was before I got some formal acceptance. I probably should have ended with "if nobody formally accepts by then", which was the intention. This patch had been open for a week...

REPOSITORY
R241 KIO

REVISION DETAIL
https://phabricator.kde.org/D11767

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, davidedmundson
Cc: rkflx, davidedmundson, michaelh, sharvey, elvisangelaccio, abetts, rizzitello, ngraham

[Henrik Fehlauer]

rkflx added a comment.

Post by Nathaniel Graham
That was before I got some formal acceptance. I probably should have ended with "if nobody formally accepts by then", which was the intention. This patch had been open for a week...

Then don't set #gwenview <https://phabricator.kde.org/tag/gwenview/> as a reviewer and announce that you'll give time for review until the weekend. Some people have other plans in the Easter week


REPOSITORY
R241 KIO

REVISION DETAIL
https://phabricator.kde.org/D11767

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, davidedmundson
Cc: rkflx, davidedmundson, michaelh, sharvey, elvisangelaccio, abetts, rizzitello, ngraham

[Nathaniel Graham]

ngraham removed a dependent revision: D11768: Add Desktop and Downloads to the default list of Places.

REPOSITORY
R241 KIO

REVISION DETAIL
https://phabricator.kde.org/D11767

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, davidedmundson
Cc: rkflx, davidedmundson, michaelh, sharvey, elvisangelaccio, abetts, rizzitello, bruns

[Nathaniel Graham]

ngraham added a task: T8349: Improve Places panel usability and presentation.
Herald added a subscriber: kde-frameworks-devel.

REPOSITORY
R241 KIO

REVISION DETAIL
https://phabricator.kde.org/D11767

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, davidedmundson
Cc: kde-frameworks-devel, rkflx, davidedmundson, michaelh, sharvey, elvisangelaccio, abetts, rizzitello, ngraham, bruns