D16872: Add FileItemActionPlugin for tag manipulation

[Nicolas Fella]

nicolasfella added reviewers: Dolphin, VDG.

REPOSITORY
R824 Baloo Widgets

REVISION DETAIL
https://phabricator.kde.org/D16872

To: nicolasfella, #baloo, broulik, ngraham, #dolphin, #vdg
Cc: ashaposhnikov, astippich, spoorun, abrahams

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


Nice!

It should to be possible to show the context menu entry for folders, too, since they can also be tagged.

INLINE COMMENTS

tagsfileitemaction.cpp:43
+{
+ m_menu = new QMenu(i18n("Tags"));
+ m_menu->setIcon(QIcon::fromTheme(QStringLiteral("tag")));

Can we change this to use an action verb?

Like "Assign Tags" or "Tag this Item" or something like that.

tagsfileitemaction.cpp:71
+
+ QAction* newAction = new QAction(i18n("Create new"));
+ newAction->setIcon(QIcon::fromTheme(QStringLiteral("tag")));

Needs to be in Title Case and have ellipses: "Create New..."

REPOSITORY
R824 Baloo Widgets

REVISION DETAIL
https://phabricator.kde.org/D16872

To: nicolasfella, #baloo, broulik, ngraham, #dolphin, #vdg
Cc: ashaposhnikov, astippich, spoorun, abrahams

[Nicolas Fella]

nicolasfella updated this revision to Diff 45456.
nicolasfella added a comment.


- Show for directories
- Use verb
- Case and ellipsis

REPOSITORY
R824 Baloo Widgets

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16872?vs=45441&id=45456

BRANCH
fiap

REVISION DETAIL
https://phabricator.kde.org/D16872

AFFECTED FILES
src/CMakeLists.txt
src/tagsfileitemactionplugin/CMakeLists.txt
src/tagsfileitemactionplugin/Messages.sh
src/tagsfileitemactionplugin/tagsfileitemaction.cpp
src/tagsfileitemactionplugin/tagsfileitemaction.h
src/tagsfileitemactionplugin/tagsfileitemaction.json

To: nicolasfella, #baloo, broulik, ngraham, #dolphin, #vdg
Cc: ashaposhnikov, astippich, spoorun, abrahams

[Nicolas Fella]

nicolasfella marked 2 inline comments as done.

REPOSITORY
R824 Baloo Widgets

REVISION DETAIL
https://phabricator.kde.org/D16872

To: nicolasfella, #baloo, broulik, ngraham, #dolphin, #vdg
Cc: ashaposhnikov, astippich, spoorun, abrahams

[Nicolas Fella]

nicolasfella edited the summary of this revision.

REPOSITORY
R824 Baloo Widgets

REVISION DETAIL
https://phabricator.kde.org/D16872

To: nicolasfella, #baloo, broulik, ngraham, #dolphin, #vdg
Cc: ashaposhnikov, astippich, spoorun, abrahams

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


Thanks, looks great and works great!

REPOSITORY
R824 Baloo Widgets

BRANCH
fiap

REVISION DETAIL
https://phabricator.kde.org/D16872

To: nicolasfella, #baloo, broulik, ngraham, #dolphin, #vdg
Cc: ashaposhnikov, astippich, spoorun, abrahams

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R824:597e610e99b5: Add FileItemActionPlugin for tag manipulation (authored by nicolasfella).

REPOSITORY
R824 Baloo Widgets

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16872?vs=45456&id=45460

REVISION DETAIL
https://phabricator.kde.org/D16872

AFFECTED FILES
src/CMakeLists.txt
src/tagsfileitemactionplugin/CMakeLists.txt
src/tagsfileitemactionplugin/Messages.sh
src/tagsfileitemactionplugin/tagsfileitemaction.cpp
src/tagsfileitemactionplugin/tagsfileitemaction.h
src/tagsfileitemactionplugin/tagsfileitemaction.json

To: nicolasfella, #baloo, broulik, ngraham, #dolphin, #vdg
Cc: ashaposhnikov, astippich, spoorun, abrahams

[Elvis Angelaccio]

elvisangelaccio added a comment.


Shouldn't the plugin check whether the file is writable? I don't think we can add tags to root-owned files, do we?

REPOSITORY
R824 Baloo Widgets

REVISION DETAIL
https://phabricator.kde.org/D16872

To: nicolasfella, #baloo, broulik, ngraham, #dolphin, #vdg
Cc: elvisangelaccio, ashaposhnikov, astippich, spoorun, abrahams