D15557: Improve "insufficient disk space" error messgae

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Frameworks, VDG, Dolphin, shubham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
The prior error was misleading, and always said "Disk full." even when the disk wasn't actually full; not having enough space to move or copy the requested file doesn't mean that the disk is full! This patch re-words the error message to be clearer and still work when `errorString` is defined (as it always should be).

TEST PLAN
Before:

After:

REPOSITORY
R241 KIO

BRANCH
improve-insufficient-disk-space-error-message (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D15557

AFFECTED FILES
src/core/job_error.cpp

To: ngraham, #frameworks, #vdg, #dolphin, shubham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
R241 KIO

REVISION DETAIL
https://phabricator.kde.org/D15557

To: ngraham, #frameworks, #vdg, #dolphin, shubham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

[Shubham]

shubham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
R241 KIO

BRANCH
improve-insufficient-disk-space-error-message (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D15557

To: ngraham, #frameworks, #vdg, #dolphin, shubham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

[Andres Betts]

abetts added a comment.


I like the proposal already. I would just add other strings for perspective:

- Cannot move file. File larger than remaining space.
- Unable to move file, insufficient space remaining.

REPOSITORY
R241 KIO

BRANCH
improve-insufficient-disk-space-error-message (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D15557

To: ngraham, #frameworks, #vdg, #dolphin, shubham
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

[Nathaniel Graham]

ngraham added a comment.


We can't use the words "file" or "move" since this part of the code can't know whether the user is moving or copying, or whether the thing being moved or copied is a file or a directory. Adjusting the code here to know those pieces of information not easily possible and would involve patches to multiple other repos--and it's also out of scope for this patch. :)

REPOSITORY
R241 KIO

BRANCH
improve-insufficient-disk-space-error-message (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D15557

To: ngraham, #frameworks, #vdg, #dolphin, shubham
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

[Andres Betts]

abetts added a comment.

Post by Nathaniel Graham
We can't use the words "file" or "move" since this part of the code can't know whether the user is moving or copying, or whether the thing being moved or copied is a file or a directory. Adjusting the code here to know those pieces of information not easily possible and would involve patches to multiple other repos--and it's also out of scope for this patch. :)

Not married to any string. I think the patch is already improving it, just showing some perspective. I guess my main angle is to communicate the information as soon as the sentence starts. Something like "Not enough" or "Unable to" right off the bat so it can have a more immediate understanding from the user. ;)

REPOSITORY
R241 KIO

BRANCH
improve-insufficient-disk-space-error-message (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D15557

To: ngraham, #frameworks, #vdg, #dolphin, shubham
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

[Kai Uwe Broulik]

broulik added a comment.


+1

REPOSITORY
R241 KIO

BRANCH
improve-insufficient-disk-space-error-message (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D15557

To: ngraham, #frameworks, #vdg, #dolphin, shubham
Cc: broulik, abetts, kde-frameworks-devel, michaelh, ngraham, bruns

[Shubham]

shubham added a comment.


Maybe "Dont have enough space available on the disk"

REPOSITORY
R241 KIO

BRANCH
improve-insufficient-disk-space-error-message (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D15557

To: ngraham, #frameworks, #vdg, #dolphin, shubham
Cc: broulik, abetts, kde-frameworks-devel, michaelh, ngraham, bruns

[Nathaniel Graham]

ngraham retitled this revision from "Improve "insufficient disk space" error messgae" to "Improve "insufficient disk space" error message".

REPOSITORY
R241 KIO

BRANCH
improve-insufficient-disk-space-error-message (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D15557

To: ngraham, #frameworks, #vdg, #dolphin, shubham
Cc: broulik, abetts, kde-frameworks-devel, michaelh, ngraham, bruns

[Nathaniel Graham]

ngraham closed this revision.

REPOSITORY
R241 KIO

REVISION DETAIL
https://phabricator.kde.org/D15557

To: ngraham, #frameworks, #vdg, #dolphin, shubham
Cc: broulik, abetts, kde-frameworks-devel, michaelh, ngraham, bruns