D11382: Add an option to show tabs from last time when Dolphin starts

[Roman Inflianskas]

rominf created this revision.
rominf added a reviewer: Dolphin.
rominf requested review of this revision.

REVISION SUMMARY
Many web browsers (Firefox for example) offer a function to show tabs from last time when a browser starts. This patch implements this functionality as an option.

TEST PLAN
1. Go to Settings > Configure Dolphin... > Startup
2. Check the [X] Show tabs from last time
3. Save settings
4. Open a few tabs (probably with the splits)
5. Close the Dolphin
6. Observe no notification on closing multiple tabs
7. Open Dolphin
8. Observe tabs and splits from last time

REPOSITORY
R318 Dolphin

BRANCH
save-window-state

REVISION DETAIL
https://phabricator.kde.org/D11382

AFFECTED FILES
src/dolphinmainwindow.cpp
src/settings/dolphin_generalsettings.kcfg
src/settings/startup/startupsettingspage.cpp
src/settings/startup/startupsettingspage.h

To: rominf, #dolphin
Cc: #dolphin

[Roman Inflianskas]

rominf edited the test plan for this revision.

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D11382

To: rominf, #dolphin
Cc: #dolphin

[Roman Inflianskas]

rominf edited the test plan for this revision.

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D11382

To: rominf, #dolphin
Cc: #dolphin

[Roman Inflianskas]

rominf edited the test plan for this revision.

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D11382

To: rominf, #dolphin
Cc: #dolphin

[Kai Uwe Broulik]

broulik added a comment.


How does that behave when I start Dolphin a second time? I'm a person that usually has 5 Dolphin windows open with tons of tabs inside of them.

INLINE COMMENTS

dolphinmainwindow.cpp:186
+ QTimer::singleShot(0, [this]() {
+ KConfigGroup windowState{KSharedConfig::openConfig(QStringLiteral("dolphinrc")), "WindowState"};
+ readProperties(windowState);

Instead of hardcoding those settings everywhere, please use KConfigXt (the `kcfg` files you can see for other places in Dolphin), like `GeneralSettings`

startupsettingspage.cpp:95
+ vBoxLayout->addWidget(m_rememberOpenedTabs);

This wording could be improved (can't think of one right now)

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D11382

To: rominf, #dolphin
Cc: broulik, #dolphin

[Roman Inflianskas]

rominf added a comment.

Post by Kai Uwe Broulik
How does that behave when I start Dolphin a second time? I'm a person that usually has 5 Dolphin windows open with tons of tabs inside of them.

It opens a new instance of Dolphin identical to the previous one... I guess that's a wrong behavior. Should the new instance be fresh if there are other Dolphins running?

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D11382

To: rominf, #dolphin
Cc: broulik, #dolphin

[Kai Uwe Broulik]

broulik added a comment.

Post by Roman Inflianskas
It opens a new instance of Dolphin identical to the previous one... I guess that's a wrong behavior. Should the new instance be fresh if there are other Dolphins running?

I don't know. Perhaps restore the set only once? (This would make for an awesome crash recovery feature btw) Best add VDG team as reviewers so they can chime in

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D11382

To: rominf, #dolphin
Cc: broulik, #dolphin

[Roman Inflianskas]

rominf added a reviewer: VDG.

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D11382

To: rominf, #dolphin, #vdg
Cc: broulik, #dolphin