Discussion:
D16824: [PlacesPanel] Port to KFilePlaceEditDialog
Elvis Angelaccio
2018-11-11 18:14:10 UTC
Permalink
elvisangelaccio created this revision.
elvisangelaccio added a reviewer: Dolphin.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
elvisangelaccio requested review of this revision.

REVISION SUMMARY
This patch ports away from the old PlacesItemEditDialog copy,
which doesn't honour the "applicationLocal" checkbox.

KFilePlaceEditDialog was not exported by KIO, but it will be starting
from 5.53

BUG: 376619
FIXED-IN: 19.03.80

TEST PLAN
- Create a new place ("Add Entry" from the panel context menu) and check the "only show in dolphin" checkbox
- Edit an existing (global) place and check the "only show in dolphin" checkbox

REPOSITORY
R318 Dolphin

BRANCH
kfileplaceeditdialog-port (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D16824

AFFECTED FILES
CMakeLists.txt
src/CMakeLists.txt
src/panels/places/placesitemeditdialog.cpp
src/panels/places/placesitemeditdialog.h
src/panels/places/placespanel.cpp

To: elvisangelaccio, #dolphin
Cc: kfm-devel, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
Elvis Angelaccio
2018-11-11 18:16:53 UTC
Permalink
elvisangelaccio added a dependency: D16825: Export again KFilePlaceEditDialog.

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D16824

To: elvisangelaccio, #dolphin
Cc: kfm-devel, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
Elvis Angelaccio
2018-11-11 18:17:52 UTC
Permalink
elvisangelaccio added a task: T8349: Improve Places panel usability and presentation.

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D16824

To: elvisangelaccio, #dolphin
Cc: kfm-devel, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
Elvis Angelaccio
2018-11-11 18:18:18 UTC
Permalink
elvisangelaccio added a task: T9795: Use Places Panel code from KIO instead of private implementation.

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D16824

To: elvisangelaccio, #dolphin
Cc: kfm-devel, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
Nathaniel Graham
2018-11-13 20:44:51 UTC
Permalink
ngraham added a comment.
`FIXED-IN: 19.03.80`
Shouldn't that be 19.04.0? It doesn't matter that it will be in a future beta release; that's implied.

Also, something rather odd happens when I use the "Only show when using this application" checkbox from the new `KFilePlacesEditDialog`:

F6421527: weird-2018-11-13_13.42.41.webm <https://phabricator.kde.org/F6421527>

Not depicted in the video is the fact that any custom icon is reset, too.

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D16824

To: elvisangelaccio, #dolphin
Cc: ngraham, kfm-devel, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
Nathaniel Graham
2018-11-13 20:45:31 UTC
Permalink
ngraham edited the summary of this revision.

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D16824

To: elvisangelaccio, #dolphin
Cc: ngraham, kfm-devel, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
Elvis Angelaccio
2018-11-17 15:44:21 UTC
Permalink
elvisangelaccio updated this revision to Diff 45671.
elvisangelaccio added a comment.


- Properly pass places' labels to the dialog

REPOSITORY
R318 Dolphin

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16824?vs=45312&id=45671

BRANCH
kfileplaceeditdialog-port (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D16824

AFFECTED FILES
CMakeLists.txt
src/CMakeLists.txt
src/panels/places/placesitemeditdialog.cpp
src/panels/places/placesitemeditdialog.h
src/panels/places/placespanel.cpp

To: elvisangelaccio, #dolphin
Cc: ngraham, kfm-devel, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
Elvis Angelaccio
2018-11-17 15:47:06 UTC
Permalink
elvisangelaccio added a comment.
Post by Nathaniel Graham
`FIXED-IN: 19.03.80`
Shouldn't that be 19.04.0? It doesn't matter that it will be in a future beta release; that's implied.
Well, not if the bug gets fixed after the beta was tagged. Then the fix would be in the RC (`XX.YY.90`) but not in the beta.

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D16824

To: elvisangelaccio, #dolphin
Cc: ngraham, kfm-devel, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
Nathaniel Graham
2018-11-20 00:08:54 UTC
Permalink
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


Thanks, that fixed it. Everything else seems to work too.

REPOSITORY
R318 Dolphin

BRANCH
kfileplaceeditdialog-port (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D16824

To: elvisangelaccio, #dolphin, ngraham
Cc: ngraham, kfm-devel, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
Elvis Angelaccio
2018-11-24 12:26:01 UTC
Permalink
This revision was automatically updated to reflect the committed changes.
Closed by commit R318:b5df5f4d9581: [PlacesPanel] Port to KFilePlaceEditDialog (authored by elvisangelaccio).

REPOSITORY
R318 Dolphin

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16824?vs=45671&id=46113

REVISION DETAIL
https://phabricator.kde.org/D16824

AFFECTED FILES
CMakeLists.txt
src/CMakeLists.txt
src/panels/places/placesitemeditdialog.cpp
src/panels/places/placesitemeditdialog.h
src/panels/places/placespanel.cpp

To: elvisangelaccio, #dolphin, ngraham
Cc: ngraham, kfm-devel, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
Loading...