D16307: [KStandardItemListWidget] Pass icon state to overlay painter

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Dolphin, VDG.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
broulik requested review of this revision.

REVISION SUMMARY
Ensures the overlay is painted in the same icon state, especially the selected one so dark overlays turn white.

TEST PLAN
Before
F6338023: Screenshot_20181019_074852.png <https://phabricator.kde.org/F6338023>
After
F6338025: Screenshot_20181019_074843.png <https://phabricator.kde.org/F6338025>

No change for icon view as there (currently) is no highlight behind it

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D16307

AFFECTED FILES
src/kitemviews/kstandarditemlistwidget.cpp

To: broulik, #dolphin, #vdg
Cc: kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp

[Kai Uwe Broulik]

broulik edited the test plan for this revision.

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D16307

To: broulik, #dolphin, #vdg
Cc: kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp

[Elvis Angelaccio]

elvisangelaccio accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D16307

To: broulik, #dolphin, #vdg, elvisangelaccio
Cc: kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp

[Nathaniel Graham]

ngraham added a comment.

No change for when file has a preview as there you could end up with a white emblem on a white image

Not sure this is semantically correct. The fact that some emblems are white with no border is an implementation detail that Dolphin shouldn't have to care about. And we're fixing it soon anyway: https://bugs.kde.org/show_bug.cgi?id=399357

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D16307

To: broulik, #dolphin, #vdg, elvisangelaccio
Cc: ngraham, kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp

[Kai Uwe Broulik]

broulik added a comment.

Post by Nathaniel Graham
Not sure this is semantically correct. The fact that some emblems are white with no border is an implementation detail that Dolphin shouldn't have to care about.

I agree, it's a separate issue, though, as I would have expected this codepath to also affect files with thumbnails but it does not, the overlays for thumbnails are painted in `KFileItemModelRolesUpdater::slotGotPreview` instead which doesn't have any notion of selected/hovered.

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D16307

To: broulik, #dolphin, #vdg, elvisangelaccio
Cc: ngraham, kfm-devel, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


Cool, let's do it then.

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D16307

To: broulik, #dolphin, #vdg, elvisangelaccio, ngraham
Cc: ngraham, kfm-devel, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R318:502a5c86feb0: [KStandardItemListWidget] Pass icon state to overlay painter (authored by broulik).

REPOSITORY
R318 Dolphin

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16307?vs=43900&id=44139

REVISION DETAIL
https://phabricator.kde.org/D16307

AFFECTED FILES
src/kitemviews/kstandarditemlistwidget.cpp

To: broulik, #dolphin, #vdg, elvisangelaccio, ngraham
Cc: ngraham, kfm-devel, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp