Discussion:
Review Request 108399: Add option to make Dolphin split the view horizontally instead of vertically
(too old to reply)
Kai Uwe Broulik
2013-01-13 21:22:41 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108399/
-----------------------------------------------------------

Review request for Dolphin and Frank Reininghaus.


Description
-------

Turned out to be a rather straight-foward patch. This adds a config option to Dolphin's behavior settings so you can set it to split the view horizontally (ie. top and bottom) rather than the default vertically (left and right).

I am planning to enhance this overall behavior a bit, but this is the initial thing. Please comment on my idea/plan:
[Split] gets a delayed popup menu: Split Vertically, Split Horizontally. When you just click the button it will just split according to the setings (Vertically by default)
[Close] gets a delayed popup menu: Close left view, Close right view (top and bottom, respectively, so you can control which view to close. When you just click the button it will just close the active view, like it does right now. (Maybe I will even add an option for that as well, so if you preferr that it closes the inactive view by default, that you can do this, since we now already have a "Split" section in the settings). Let me know what you think. :-)


This addresses bug 168592.
http://bugs.kde.org/show_bug.cgi?id=168592


Diffs
-----

dolphin/src/settings/general/behaviorsettingspage.cpp cbbde1d
dolphin/src/settings/general/behaviorsettingspage.h 7a9c2f0
dolphin/src/dolphinmainwindow.cpp 11e03d0
dolphin/src/settings/dolphin_generalsettings.kcfg 849a9c7

Diff: http://git.reviewboard.kde.org/r/108399/diff/


Testing
-------

Opened dolphin, split view, closed split view, changed the setting, split again, closed again. And tried with --split cmdline parameter. All worked.


Thanks,

Kai Uwe Broulik
Frank Reininghaus
2013-01-14 09:38:59 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108399/#review25434
-----------------------------------------------------------


Thanks for the patch, but to be honest, I'm not convinced that we really need this. Splitting the view left/right is so extremely much more common (also in other KDE/non-KDE apps) that I'm not sure if adding options and additional menus for this corner case is justified.

Moreover, there are more things that would need to be changed or adjusted. The Split/Close icon comes to my mind, but there are probably more. In my experience, after a new little feature is added, users always find lots of details that don't work as intended.

IMHO, users who really want two views at the top and the bottom of the screen could either open two separate Dolphin windows, or use Konqueror, which has way more advanced splitting options anyway.

- Frank Reininghaus
Post by Kai Uwe Broulik
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/108399/
-----------------------------------------------------------
(Updated Jan. 13, 2013, 9:22 p.m.)
Review request for Dolphin and Frank Reininghaus.
Description
-------
Turned out to be a rather straight-foward patch. This adds a config option to Dolphin's behavior settings so you can set it to split the view horizontally (ie. top and bottom) rather than the default vertically (left and right).
[Split] gets a delayed popup menu: Split Vertically, Split Horizontally. When you just click the button it will just split according to the setings (Vertically by default)
[Close] gets a delayed popup menu: Close left view, Close right view (top and bottom, respectively, so you can control which view to close. When you just click the button it will just close the active view, like it does right now. (Maybe I will even add an option for that as well, so if you preferr that it closes the inactive view by default, that you can do this, since we now already have a "Split" section in the settings). Let me know what you think. :-)
This addresses bug 168592.
http://bugs.kde.org/show_bug.cgi?id=168592
Diffs
-----
dolphin/src/settings/general/behaviorsettingspage.cpp cbbde1d
dolphin/src/settings/general/behaviorsettingspage.h 7a9c2f0
dolphin/src/dolphinmainwindow.cpp 11e03d0
dolphin/src/settings/dolphin_generalsettings.kcfg 849a9c7
Diff: http://git.reviewboard.kde.org/r/108399/diff/
Testing
-------
Opened dolphin, split view, closed split view, changed the setting, split again, closed again. And tried with --split cmdline parameter. All worked.
Thanks,
Kai Uwe Broulik
Kai Uwe Broulik
2015-12-15 21:49:22 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/108399/
-----------------------------------------------------------

(Updated Dez. 15, 2015, 9:49 nachm.)


Status
------

This change has been discarded.


Review request for Dolphin and Frank Reininghaus.


Bugs: 168592
http://bugs.kde.org/show_bug.cgi?id=168592


Repository: kde-baseapps


Description
-------

Turned out to be a rather straight-foward patch. This adds a config option to Dolphin's behavior settings so you can set it to split the view horizontally (ie. top and bottom) rather than the default vertically (left and right).

I am planning to enhance this overall behavior a bit, but this is the initial thing. Please comment on my idea/plan:
[Split] gets a delayed popup menu: Split Vertically, Split Horizontally. When you just click the button it will just split according to the setings (Vertically by default)
[Close] gets a delayed popup menu: Close left view, Close right view (top and bottom, respectively, so you can control which view to close. When you just click the button it will just close the active view, like it does right now. (Maybe I will even add an option for that as well, so if you preferr that it closes the inactive view by default, that you can do this, since we now already have a "Split" section in the settings). Let me know what you think. :-)


Diffs
-----

dolphin/src/settings/general/behaviorsettingspage.cpp cbbde1d
dolphin/src/settings/general/behaviorsettingspage.h 7a9c2f0
dolphin/src/dolphinmainwindow.cpp 11e03d0
dolphin/src/settings/dolphin_generalsettings.kcfg 849a9c7

Diff: https://git.reviewboard.kde.org/r/108399/diff/


Testing
-------

Opened dolphin, split view, closed split view, changed the setting, split again, closed again. And tried with --split cmdline parameter. All worked.


Thanks,

Kai Uwe Broulik

Loading...