D12761: Allow building kio-nfs against standalone libtirpc

[Andreas Sturmlechner]

asturmlechner added inline comments.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.

INLINE COMMENTS

CMakeLists.txt:175
+ add_feature_info("NFS kioslave" RPC_H_DIR "The RPC library is needed to build the NFS kioslave")
+ if(RPC_H_DIR)
add_subdirectory( nfs )

I would prefer a real build option instead of automagic here, and the detection below that conditional. I'm aware that's more than what we have right now.

cgiboudeaux wrote in CMakeLists.txt:4
This won't work for openSUSE: the tirpc headers are installed in /usr/include directly.

Could you suggest an alternative? Gentoo shares a similarity with Arch there, because otherwise libtirpc could collide with older versions of glibc.

REPOSITORY
R320 KIO Extras

REVISION DETAIL
https://phabricator.kde.org/D12761

To: arojas, dfaure, rdieter, asturmlechner, cgiboudeaux
Cc: kde-frameworks-devel, kfm-devel, cgiboudeaux, ngraham, alexde, sourabhboss, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, mikesomov

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

asturmlechner wrote in CMakeLists.txt:4
Could you suggest an alternative? Gentoo shares a similarity with Arch there, because otherwise libtirpc could collide with older versions of glibc.

I added the solution we use in openSUSE: https://paste.kde.org/pscug8tik

REPOSITORY
R320 KIO Extras

REVISION DETAIL
https://phabricator.kde.org/D12761

To: arojas, dfaure, rdieter, asturmlechner, cgiboudeaux
Cc: kde-frameworks-devel, kfm-devel, cgiboudeaux, ngraham, alexde, sourabhboss, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, mikesomov

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

cgiboudeaux wrote in CMakeLists.txt:4
I added the solution we use in openSUSE: https://paste.kde.org/pscug8tik

Any solution is fine however, we now patched ours kdebase4-runtime package to disable kio-nfs completely. Pick the solution you prefer.

REPOSITORY
R320 KIO Extras

REVISION DETAIL
https://phabricator.kde.org/D12761

To: arojas, dfaure, rdieter, asturmlechner, cgiboudeaux
Cc: kde-frameworks-devel, kfm-devel, cgiboudeaux, ngraham, alexde, sourabhboss, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, mikesomov

[Andreas Sturmlechner]

asturmlechner added inline comments.

INLINE COMMENTS

cgiboudeaux wrote in CMakeLists.txt:4
Any solution is fine however, we now patched ours kdebase4-runtime package to disable kio-nfs completely. Pick the solution you prefer.

Thanks, your FindTIRPC works for me. This is what I came up with using it: https://paste.pound-python.org/show/zgu3uRLCJzKqXj97mL5b/

REPOSITORY
R320 KIO Extras

REVISION DETAIL
https://phabricator.kde.org/D12761

To: arojas, dfaure, rdieter, asturmlechner, cgiboudeaux
Cc: kde-frameworks-devel, kfm-devel, cgiboudeaux, ngraham, alexde, sourabhboss, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, mikesomov

[Antonio Rojas]

arojas added a comment.


@asturmlechner can you post that in a new review request? I'll abandon this one.

REPOSITORY
R320 KIO Extras

REVISION DETAIL
https://phabricator.kde.org/D12761

To: arojas, dfaure, rdieter, asturmlechner, cgiboudeaux
Cc: kde-frameworks-devel, kfm-devel, cgiboudeaux, ngraham, alexde, sourabhboss, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, mikesomov

[Andreas Sturmlechner]

asturmlechner added a comment.

Post by Antonio Rojas
@asturmlechner can you post that in a new review request? I'll abandon this one.

Done, this is now in https://phabricator.kde.org/D17205

REPOSITORY
R320 KIO Extras

REVISION DETAIL
https://phabricator.kde.org/D12761

To: arojas, dfaure, rdieter, asturmlechner, cgiboudeaux
Cc: kde-frameworks-devel, kfm-devel, cgiboudeaux, ngraham, alexde, sourabhboss, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, mikesomov

[Antonio Rojas]

arojas abandoned this revision.

REPOSITORY
R320 KIO Extras

REVISION DETAIL
https://phabricator.kde.org/D12761

To: arojas, dfaure, rdieter, asturmlechner, cgiboudeaux
Cc: kde-frameworks-devel, kfm-devel, cgiboudeaux, ngraham, alexde, sourabhboss, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, mikesomov