Discussion:
Review Request 130157: Bug 321575 - Change window title when searching
XY Quadrat
2017-06-13 16:04:49 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130157/
-----------------------------------------------------------

Review request for Dolphin.


Bugs: 321575
https://bugs.kde.org/show_bug.cgi?id=321575


Repository: dolphin


Description
-------

When you search for a file (e.g. "hello world") the window title of Dolphin will change to "Searching hello world". This commit includes moving the DolphinSearchBox object created in dolphinviewcontainer.h from private to public, so that dolphinmainwindow.cpp can access the input the user typed in.


Diffs
-----

src/dolphinmainwindow.h d741eb2
src/dolphinmainwindow.cpp 8d58043
src/dolphinviewcontainer.h e50386a

Diff: https://git.reviewboard.kde.org/r/130157/diff/


Testing
-------

- Disables it iself after search bar is hidden
- Works with multiple word searches


Thanks,

XY Quadrat
Anthony Fieroni
2017-06-13 16:27:15 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130157/#review103316
-----------------------------------------------------------



You should set window title, searchbox content is transfered to filenamesearch / baloosearch kio slaves.

- Anthony Fieroni
Post by XY Quadrat
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/130157/
-----------------------------------------------------------
(Updated ЮМО 13, 2017, 7:04 слеЎ ПбяЎ)
Review request for Dolphin.
Bugs: 321575
https://bugs.kde.org/show_bug.cgi?id=321575
Repository: dolphin
Description
-------
When you search for a file (e.g. "hello world") the window title of Dolphin will change to "Searching hello world". This commit includes moving the DolphinSearchBox object created in dolphinviewcontainer.h from private to public, so that dolphinmainwindow.cpp can access the input the user typed in.
Diffs
-----
src/dolphinmainwindow.h d741eb2
src/dolphinmainwindow.cpp 8d58043
src/dolphinviewcontainer.h e50386a
Diff: https://git.reviewboard.kde.org/r/130157/diff/
Testing
-------
- Disables it iself after search bar is hidden
- Works with multiple word searches
Thanks,
XY Quadrat
Christoph Feck
2017-06-13 19:08:06 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130157/#review103317
-----------------------------------------------------------




src/dolphinmainwindow.h
<https://git.reviewboard.kde.org/r/130157/#comment68734>

Unrelated whitespace change?



src/dolphinmainwindow.cpp (line 980)
<https://git.reviewboard.kde.org/r/130157/#comment68732>

- add space after 'if'
- add space before '{'



src/dolphinmainwindow.cpp (line 981)
<https://git.reviewboard.kde.org/r/130157/#comment68733>

Use ki18n() with arguments instead of concatenation.



src/dolphinviewcontainer.h (line 96)
<https://git.reviewboard.kde.org/r/130157/#comment68735>

This is bad. If code outside of the class needs to access the m_searchBox member, we don't just make it public, but add proper access methods.

In this case, only getting the current search string is needed, so add a method something like currentSearchText().


- Christoph Feck
Post by XY Quadrat
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/130157/
-----------------------------------------------------------
(Updated June 13, 2017, 6:04 p.m.)
Review request for Dolphin.
Bugs: 321575
https://bugs.kde.org/show_bug.cgi?id=321575
Repository: dolphin
Description
-------
When you search for a file (e.g. "hello world") the window title of Dolphin will change to "Searching hello world". This commit includes moving the DolphinSearchBox object created in dolphinviewcontainer.h from private to public, so that dolphinmainwindow.cpp can access the input the user typed in.
Diffs
-----
src/dolphinmainwindow.h d741eb2
src/dolphinmainwindow.cpp 8d58043
src/dolphinviewcontainer.h e50386a
Diff: https://git.reviewboard.kde.org/r/130157/diff/
Testing
-------
- Disables it iself after search bar is hidden
- Works with multiple word searches
Thanks,
XY Quadrat
Christoph Feck
2017-06-13 19:11:39 UTC
Permalink
src/dolphinviewcontainer.h, line 96
<https://git.reviewboard.kde.org/r/130157/diff/1/?file=496259#file496259line96>
This is bad. If code outside of the class needs to access the m_searchBox member, we don't just make it public, but add proper access methods.
In this case, only getting the current search string is needed, so add a method something like currentSearchText().
Or just searchText()
Or not searchText(), because it doesn't search text :)


- Christoph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130157/#review103317
-----------------------------------------------------------
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/130157/
-----------------------------------------------------------
(Updated June 13, 2017, 9:10 p.m.)
Review request for Dolphin, Elvis Angelaccio and Emmanuel Pescosta.
Bugs: 321575
https://bugs.kde.org/show_bug.cgi?id=321575
Repository: dolphin
Description
-------
When you search for a file (e.g. "hello world") the window title of Dolphin will change to "Searching hello world". This commit includes moving the DolphinSearchBox object created in dolphinviewcontainer.h from private to public, so that dolphinmainwindow.cpp can access the input the user typed in.
Diffs
-----
src/dolphinmainwindow.h d741eb2
src/dolphinmainwindow.cpp 8d58043
src/dolphinviewcontainer.h e50386a
Diff: https://git.reviewboard.kde.org/r/130157/diff/
Testing
-------
- Disables it iself after search bar is hidden
- Works with multiple word searches
Thanks,
XY Quadrat
XY Quadrat
2017-06-14 19:24:17 UTC
Permalink
Post by XY Quadrat
src/dolphinmainwindow.cpp, line 981
<https://git.reviewboard.kde.org/r/130157/diff/1/?file=496258#file496258line981>
Use ki18n() with arguments instead of concatenation.
So I looked up the ki18n() docs and managed to get everything running & working when I use i18n("Searching %1", ...) but when I try to use ki18n() instead the compiler gives an error ("too many arguments"). Is there a reason I should use ki18n() over i18n() (apart from that it gets initialized before the QApplication instance)? And if yes, how can I get it working?


- XY


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130157/#review103317
-----------------------------------------------------------
Post by XY Quadrat
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/130157/
-----------------------------------------------------------
(Updated June 14, 2017, 7:20 p.m.)
Review request for Dolphin, Elvis Angelaccio and Emmanuel Pescosta.
Bugs: 321575
https://bugs.kde.org/show_bug.cgi?id=321575
Repository: dolphin
Description
-------
When you search for a file (e.g. "hello world") the window title of Dolphin will change to "Searching hello world". This commit includes moving the DolphinSearchBox object created in dolphinviewcontainer.h from private to public, so that dolphinmainwindow.cpp can access the input the user typed in.
Diffs
-----
src/dolphinmainwindow.cpp 8d58043
src/dolphinviewcontainer.h e50386a
src/dolphinviewcontainer.cpp 72ced93
Diff: https://git.reviewboard.kde.org/r/130157/diff/
Testing
-------
- Disables it iself after search bar is hidden
- Works with multiple word searches
Thanks,
XY Quadrat
Christoph Feck
2017-06-14 19:26:39 UTC
Permalink
Post by XY Quadrat
src/dolphinmainwindow.cpp, line 981
<https://git.reviewboard.kde.org/r/130157/diff/1/?file=496258#file496258line981>
Use ki18n() with arguments instead of concatenation.
So I looked up the ki18n() docs and managed to get everything running & working when I use i18n("Searching %1", ...) but when I try to use ki18n() instead the compiler gives an error ("too many arguments"). Is there a reason I should use ki18n() over i18n() (apart from that it gets initialized before the QApplication instance)? And if yes, how can I get it working?
Sorry my bad. It used to be called 'ki18n' in KDE4 times, now it is just 'i18n'.


- Christoph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130157/#review103317
-----------------------------------------------------------
Post by XY Quadrat
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/130157/
-----------------------------------------------------------
(Updated June 14, 2017, 9:20 p.m.)
Review request for Dolphin, Elvis Angelaccio and Emmanuel Pescosta.
Bugs: 321575
https://bugs.kde.org/show_bug.cgi?id=321575
Repository: dolphin
Description
-------
When you search for a file (e.g. "hello world") the window title of Dolphin will change to "Searching hello world". This commit includes moving the DolphinSearchBox object created in dolphinviewcontainer.h from private to public, so that dolphinmainwindow.cpp can access the input the user typed in.
Diffs
-----
src/dolphinmainwindow.cpp 8d58043
src/dolphinviewcontainer.h e50386a
src/dolphinviewcontainer.cpp 72ced93
Diff: https://git.reviewboard.kde.org/r/130157/diff/
Testing
-------
- Disables it iself after search bar is hidden
- Works with multiple word searches
Thanks,
XY Quadrat
XY Quadrat
2017-06-14 19:20:51 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130157/
-----------------------------------------------------------

(Updated June 14, 2017, 7:20 p.m.)


Review request for Dolphin, Elvis Angelaccio and Emmanuel Pescosta.


Changes
-------

- Removed unnecessary whitespace change
- Added whitespace at the if statement
- Use i18n() instead of concatenating
- Move the search text lookup into own function & m_searchBox back into private


Bugs: 321575
https://bugs.kde.org/show_bug.cgi?id=321575


Repository: dolphin


Description
-------

When you search for a file (e.g. "hello world") the window title of Dolphin will change to "Searching hello world". This commit includes moving the DolphinSearchBox object created in dolphinviewcontainer.h from private to public, so that dolphinmainwindow.cpp can access the input the user typed in.


Diffs (updated)
-----

src/dolphinmainwindow.cpp 8d58043
src/dolphinviewcontainer.h e50386a
src/dolphinviewcontainer.cpp 72ced93

Diff: https://git.reviewboard.kde.org/r/130157/diff/


Testing
-------

- Disables it iself after search bar is hidden
- Works with multiple word searches


Thanks,

XY Quadrat
Elvis Angelaccio
2017-06-14 20:58:13 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130157/#review103322
-----------------------------------------------------------



+1, looks good to me now.

- Elvis Angelaccio
Post by XY Quadrat
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/130157/
-----------------------------------------------------------
(Updated June 14, 2017, 7:20 p.m.)
Review request for Dolphin, Elvis Angelaccio and Emmanuel Pescosta.
Bugs: 321575
https://bugs.kde.org/show_bug.cgi?id=321575
Repository: dolphin
Description
-------
When you search for a file (e.g. "hello world") the window title of Dolphin will change to "Searching hello world". This commit includes moving the DolphinSearchBox object created in dolphinviewcontainer.h from private to public, so that dolphinmainwindow.cpp can access the input the user typed in.
Diffs
-----
src/dolphinmainwindow.cpp 8d58043
src/dolphinviewcontainer.h e50386a
src/dolphinviewcontainer.cpp 72ced93
Diff: https://git.reviewboard.kde.org/r/130157/diff/
Testing
-------
- Disables it iself after search bar is hidden
- Works with multiple word searches
Thanks,
XY Quadrat
XY Quadrat
2017-06-22 16:30:52 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130157/
-----------------------------------------------------------

(Updated Juni 22, 2017, 4:30 nachm.)


Review request for Dolphin, Elvis Angelaccio and Emmanuel Pescosta.


Changes
-------

Changed currentSearchText() to const


Bugs: 321575
https://bugs.kde.org/show_bug.cgi?id=321575


Repository: dolphin


Description
-------

When you search for a file (e.g. "hello world") the window title of Dolphin will change to "Searching hello world". This commit includes moving the DolphinSearchBox object created in dolphinviewcontainer.h from private to public, so that dolphinmainwindow.cpp can access the input the user typed in.


Diffs (updated)
-----

src/dolphinmainwindow.cpp 8d58043
src/dolphinviewcontainer.h e50386a
src/dolphinviewcontainer.cpp 72ced93

Diff: https://git.reviewboard.kde.org/r/130157/diff/


Testing
-------

- Disables it iself after search bar is hidden
- Works with multiple word searches


Thanks,

XY Quadrat
XY Quadrat
2017-06-22 16:57:15 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130157/
-----------------------------------------------------------

(Updated Juni 22, 2017, 4:57 nachm.)


Review request for Dolphin, Elvis Angelaccio and Emmanuel Pescosta.


Changes
-------

Same as revision 3, upload failed


Bugs: 321575
https://bugs.kde.org/show_bug.cgi?id=321575


Repository: dolphin


Description
-------

When you search for a file (e.g. "hello world") the window title of Dolphin will change to "Searching hello world". This commit includes moving the DolphinSearchBox object created in dolphinviewcontainer.h from private to public, so that dolphinmainwindow.cpp can access the input the user typed in.


Diffs (updated)
-----

src/dolphinmainwindow.cpp 8d58043
src/dolphinviewcontainer.h e50386a
src/dolphinviewcontainer.cpp 72ced93

Diff: https://git.reviewboard.kde.org/r/130157/diff/


Testing
-------

- Disables it iself after search bar is hidden
- Works with multiple word searches


Thanks,

XY Quadrat
Elvis Angelaccio
2017-06-26 13:38:16 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130157/#review103369
-----------------------------------------------------------



Please update the commit message, it's no longer true that "... moving the DolphinSearchBox object created in dolphinviewcontainer.h from private to public".

Also, add "BUG: 321575" so that the bug report will be automatically closed after pushing the commit.

- Elvis Angelaccio
Post by XY Quadrat
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/130157/
-----------------------------------------------------------
(Updated June 22, 2017, 4:57 p.m.)
Review request for Dolphin, Elvis Angelaccio and Emmanuel Pescosta.
Bugs: 321575
https://bugs.kde.org/show_bug.cgi?id=321575
Repository: dolphin
Description
-------
When you search for a file (e.g. "hello world") the window title of Dolphin will change to "Searching hello world". This commit includes moving the DolphinSearchBox object created in dolphinviewcontainer.h from private to public, so that dolphinmainwindow.cpp can access the input the user typed in.
Diffs
-----
src/dolphinmainwindow.cpp 8d58043
src/dolphinviewcontainer.h e50386a
src/dolphinviewcontainer.cpp 72ced93
Diff: https://git.reviewboard.kde.org/r/130157/diff/
Testing
-------
- Disables it iself after search bar is hidden
- Works with multiple word searches
Thanks,
XY Quadrat
XY Quadrat
2017-06-26 15:46:58 UTC
Permalink
Post by XY Quadrat
Post by Elvis Angelaccio
Please update the commit message, it's no longer true that "... moving the DolphinSearchBox object created in dolphinviewcontainer.h from private to public".
Also, add "BUG: 321575" so that the bug report will be automatically closed after pushing the commit.
Updated commit message. Do I need to simply put BUG 321575 somewhere in the description or as the title?


- XY


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130157/#review103369
-----------------------------------------------------------
Post by XY Quadrat
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/130157/
-----------------------------------------------------------
(Updated Juni 22, 2017, 4:57 nachm.)
Review request for Dolphin, Elvis Angelaccio and Emmanuel Pescosta.
Bugs: 321575
https://bugs.kde.org/show_bug.cgi?id=321575
Repository: dolphin
Description
-------
When you search for a file (e.g. "hello world") the window title of Dolphin will change to "Searching hello world". This commit includes moving the DolphinSearchBox object created in dolphinviewcontainer.h from private to public, so that dolphinmainwindow.cpp can access the input the user typed in.
Diffs
-----
src/dolphinmainwindow.cpp 8d58043
src/dolphinviewcontainer.h e50386a
src/dolphinviewcontainer.cpp 72ced93
Diff: https://git.reviewboard.kde.org/r/130157/diff/
Testing
-------
- Disables it iself after search bar is hidden
- Works with multiple word searches
Thanks,
XY Quadrat
Elvis Angelaccio
2017-06-26 13:44:01 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130157/#review103370
-----------------------------------------------------------



One more thing that I just noticed: this patch doesn't change the tab titles, they still show "baloosearch". I wonder if we should just show a generic string "Searching..." that we could use also for tabs. Input from the VDG would be nice (you can add the 'usability' group as reviewers).

- Elvis Angelaccio
Post by XY Quadrat
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/130157/
-----------------------------------------------------------
(Updated June 22, 2017, 4:57 p.m.)
Review request for Dolphin, Elvis Angelaccio and Emmanuel Pescosta.
Bugs: 321575
https://bugs.kde.org/show_bug.cgi?id=321575
Repository: dolphin
Description
-------
When you search for a file (e.g. "hello world") the window title of Dolphin will change to "Searching hello world". This commit includes moving the DolphinSearchBox object created in dolphinviewcontainer.h from private to public, so that dolphinmainwindow.cpp can access the input the user typed in.
Diffs
-----
src/dolphinmainwindow.cpp 8d58043
src/dolphinviewcontainer.h e50386a
src/dolphinviewcontainer.cpp 72ced93
Diff: https://git.reviewboard.kde.org/r/130157/diff/
Testing
-------
- Disables it iself after search bar is hidden
- Works with multiple word searches
Thanks,
XY Quadrat
XY Quadrat
2017-06-26 15:47:03 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130157/
-----------------------------------------------------------

(Updated Juni 26, 2017, 3:47 nachm.)


Review request for Dolphin, KDE Usability, Elvis Angelaccio, and Emmanuel Pescosta.


Bugs: 321575
https://bugs.kde.org/show_bug.cgi?id=321575


Repository: dolphin


Description (updated)
-------

When you search for a file (e.g. "hello world") the window title of Dolphin will change to "Searching hello world". This commit includes creating a helper function currentSearchText() in dolphinviewcontainer.cpp which then gets called from dolphinmainwindow.cpp.

This fixes BUG: 321575


Diffs
-----

src/dolphinmainwindow.cpp 8d58043
src/dolphinviewcontainer.h e50386a
src/dolphinviewcontainer.cpp 72ced93

Diff: https://git.reviewboard.kde.org/r/130157/diff/


Testing
-------

- Disables it iself after search bar is hidden
- Works with multiple word searches


Thanks,

XY Quadrat
XY Quadrat
2017-06-29 19:15:02 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130157/#review103384
-----------------------------------------------------------



I just noticed that this problem (that the window title is not really descriptive or not translated) is also occurring with e.g. the trash (the window title is simply "trash - / -- Dolphin" and is not translated). So maybe a deeper change is required if we do not want to add an extra case for every situation.

- XY Quadrat
Post by XY Quadrat
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/130157/
-----------------------------------------------------------
(Updated Juni 26, 2017, 3:47 nachm.)
Review request for Dolphin, KDE Usability, Elvis Angelaccio, and Emmanuel Pescosta.
Bugs: 321575
https://bugs.kde.org/show_bug.cgi?id=321575
Repository: dolphin
Description
-------
When you search for a file (e.g. "hello world") the window title of Dolphin will change to "Searching hello world". This commit includes creating a helper function currentSearchText() in dolphinviewcontainer.cpp which then gets called from dolphinmainwindow.cpp.
This fixes BUG: 321575
Diffs
-----
src/dolphinmainwindow.cpp 8d58043
src/dolphinviewcontainer.h e50386a
src/dolphinviewcontainer.cpp 72ced93
Diff: https://git.reviewboard.kde.org/r/130157/diff/
Testing
-------
- Disables it iself after search bar is hidden
- Works with multiple word searches
Thanks,
XY Quadrat
Elvis Angelaccio
2017-06-30 10:55:05 UTC
Permalink
Post by XY Quadrat
Post by XY Quadrat
I just noticed that this problem (that the window title is not really descriptive or not translated) is also occurring with e.g. the trash (the window title is simply "trash - / -- Dolphin" and is not translated). So maybe a deeper change is required if we do not want to add an extra case for every situation.
See https://bugs.kde.org/show_bug.cgi?id=211959


- Elvis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130157/#review103384
-----------------------------------------------------------
Post by XY Quadrat
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/130157/
-----------------------------------------------------------
(Updated June 26, 2017, 3:47 p.m.)
Review request for Dolphin, KDE Usability, Elvis Angelaccio, and Emmanuel Pescosta.
Bugs: 321575
https://bugs.kde.org/show_bug.cgi?id=321575
Repository: dolphin
Description
-------
When you search for a file (e.g. "hello world") the window title of Dolphin will change to "Searching hello world". This commit includes creating a helper function currentSearchText() in dolphinviewcontainer.cpp which then gets called from dolphinmainwindow.cpp.
This fixes BUG: 321575
Diffs
-----
src/dolphinmainwindow.cpp 8d58043
src/dolphinviewcontainer.h e50386a
src/dolphinviewcontainer.cpp 72ced93
Diff: https://git.reviewboard.kde.org/r/130157/diff/
Testing
-------
- Disables it iself after search bar is hidden
- Works with multiple word searches
Thanks,
XY Quadrat
Elvis Angelaccio
2017-10-03 21:16:29 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130157/#review103788
-----------------------------------------------------------



Reviewboard will be closed soon. Please re-upload this patch on Phabricator: https://phabricator.kde.org/differential/diff/create/

- Elvis Angelaccio
Post by XY Quadrat
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/130157/
-----------------------------------------------------------
(Updated June 26, 2017, 3:47 p.m.)
Review request for Dolphin, KDE Usability, Elvis Angelaccio, and Emmanuel Pescosta.
Bugs: 321575
https://bugs.kde.org/show_bug.cgi?id=321575
Repository: dolphin
Description
-------
When you search for a file (e.g. "hello world") the window title of Dolphin will change to "Searching hello world". This commit includes creating a helper function currentSearchText() in dolphinviewcontainer.cpp which then gets called from dolphinmainwindow.cpp.
This fixes BUG: 321575
Diffs
-----
src/dolphinmainwindow.cpp 8d58043
src/dolphinviewcontainer.h e50386a
src/dolphinviewcontainer.cpp 72ced93
Diff: https://git.reviewboard.kde.org/r/130157/diff/4/
Testing
-------
- Disables it iself after search bar is hidden
- Works with multiple word searches
Thanks,
XY Quadrat
XY Quadrat
2018-10-27 16:37:29 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130157/
-----------------------------------------------------------

(Updated Oct. 27, 2018, 4:37 p.m.)


Status
------

This change has been discarded.


Review request for Dolphin, KDE Usability, Elvis Angelaccio, and Emmanuel Pescosta.


Bugs: 321575
https://bugs.kde.org/show_bug.cgi?id=321575


Repository: dolphin


Description
-------

When you search for a file (e.g. "hello world") the window title of Dolphin will change to "Searching hello world". This commit includes creating a helper function currentSearchText() in dolphinviewcontainer.cpp which then gets called from dolphinmainwindow.cpp.

This fixes BUG: 321575


Diffs
-----

src/dolphinmainwindow.cpp 8d58043
src/dolphinviewcontainer.h e50386a
src/dolphinviewcontainer.cpp 72ced93


Diff: https://git.reviewboard.kde.org/r/130157/diff/4/


Testing
-------

- Disables it iself after search bar is hidden
- Works with multiple word searches


Thanks,

XY Quadrat

Loading...