Discussion:
D16050: Added missing QStringLiteral to Dolphin code
Alex Debus
2018-10-08 18:18:24 UTC
Permalink
alexde created this revision.
alexde added a reviewer: ngraham.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
alexde requested review of this revision.

REVISION SUMMARY
Changed

QIcon::fromTheme("icon")

to

QIcon::fromTheme(QStringLiteral("edit-entry"))

as discussed here <https://phabricator.kde.org/D16019#339284>.

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D16050

AFFECTED FILES
src/panels/places/placespanel.cpp

To: alexde, ngraham
Cc: kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
Alex Debus
2018-10-08 18:19:06 UTC
Permalink
alexde added a comment.


I hope creating a new revision for each patch was the right way to go! Also, I based this patch on the master branch and not on by branch which the other patches I submitted. Looking forward to hearing your feedback!

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D16050

To: alexde, ngraham
Cc: kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
Nathaniel Graham
2018-10-08 19:22:13 UTC
Permalink
ngraham added a reviewer: Dolphin.

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D16050

To: alexde, ngraham, #dolphin
Cc: kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
Elvis Angelaccio
2018-10-08 19:22:54 UTC
Permalink
elvisangelaccio accepted this revision.
elvisangelaccio added a comment.
This revision is now accepted and ready to land.


Thanks

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D16050

To: alexde, ngraham, #dolphin, elvisangelaccio
Cc: elvisangelaccio, kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
Nathaniel Graham
2018-10-08 19:24:08 UTC
Permalink
ngraham accepted this revision.
ngraham added a comment.


You did great! I'll land this for you later today.

Can I get an email address for you so we can properly attribute the git commit to you?

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D16050

To: alexde, ngraham, #dolphin, elvisangelaccio
Cc: elvisangelaccio, kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
Alex Debus
2018-10-08 19:35:32 UTC
Permalink
alexde added a comment.
Post by Nathaniel Graham
You did great! I'll land this for you later today.
Can I get an email address for you so we can properly attribute the git commit to you?
Sure: postix Àt posteo [dot] net

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D16050

To: alexde, ngraham, #dolphin, elvisangelaccio
Cc: elvisangelaccio, kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
Nathaniel Graham
2018-10-09 21:20:40 UTC
Permalink
ngraham closed this revision.

REPOSITORY
R318 Dolphin

REVISION DETAIL
https://phabricator.kde.org/D16050

To: alexde, ngraham, #dolphin, elvisangelaccio
Cc: elvisangelaccio, kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
Loading...